Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state_is_tuple=True: Fix training on 0.12 #4

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Conversation

julien-c
Copy link
Contributor

This parallels the changes made to char-rnn-tensorflow here: sherjilozair/char-rnn-tensorflow@991704e
which in turn parallels changes made to TF tutorial ptb_word_lm.py

@pender
Copy link
Owner

pender commented Jan 27, 2017

Isn't this already the default value of the argument? Is there a style reason why it is preferred to make the argument explicit?

@julien-c
Copy link
Contributor Author

Not sure, but it worked in my install (was failing without the change)

@pender
Copy link
Owner

pender commented Jan 27, 2017

Odd! Okay, well it can't hurt -- will merge it in. Thanks for the PR!

@pender pender merged commit a60a56e into pender:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants