Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register Pink token on Pendulum #429

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Register Pink token on Pendulum #429

merged 3 commits into from
Mar 13, 2024

Conversation

bogdanS98
Copy link
Contributor

@bogdanS98 bogdanS98 requested a review from a team March 1, 2024 16:34
ebma
ebma requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to register it here because it's an XCM asset which otherwise would not be transferrable to us.

@bogdanS98
Copy link
Contributor Author

bogdanS98 commented Mar 1, 2024 •
edited
Loading

I think we also need to register it here because it's an XCM asset which otherwise would not be transferrable to us.

I just merged main into this branch and now I have @gianfra-t's changes regarding XCM fees so we don't need this anymore

@bogdanS98 bogdanS98 requested a review from ebma March 1, 2024 17:22
ebma
ebma approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdanS98 bogdanS98 merged commit 0390a5a into main Mar 13, 2024
2 checks passed
@bogdanS98 bogdanS98 deleted the tasks/254-register-pink-token-on-pendulum branch March 13, 2024 12:39
@TorstenStueber TorstenStueber mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdanS98 @ebma