Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force-sync command to ntp-ctl #1512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rnijveld
Copy link
Member

This builds on top of #1508 which should probably be looked at first. I've made a couple of items public in implementing this. I think we could reduce the amount of duplicated code a little more by restructuring a little more, but I wanted to get a quick example of this utility as soon as possible. The source spawning currently happens in serial, but this could be made to be in parallel as well, but I don't think this tool needs to be that performant though. I wonder if we still would want to add a little more interactivity to this as well, just so users understand that this bypasses most safety checks. This fixes #1494.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 17.52137% with 193 lines in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (d3765d9) to head (3e81437).

Files Patch % Lines
ntpd/src/ctl/force_sync.rs 0.00% 177 Missing ⚠️
ntp-proto/src/source.rs 63.33% 11 Missing ⚠️
ntpd/src/ctl/mod.rs 16.66% 5 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           remove-non-basic-spawners    #1512      +/-   ##
=============================================================
- Coverage                      82.50%   81.73%   -0.78%     
=============================================================
  Files                             62       63       +1     
  Lines                          18758    18962     +204     
=============================================================
+ Hits                           15476    15498      +22     
- Misses                          3282     3464     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnijveld rnijveld linked an issue Jun 25, 2024 that may be closed by this pull request
Base automatically changed from remove-non-basic-spawners to main June 26, 2024 09:38
@davidv1992
Copy link
Member

davidv1992 commented Jun 26, 2024

@rnijveld needs rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a force-sync command to ntp-ctl
2 participants