Sidebar #110
Merged
Sidebar #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed in the past as it looked like the cause of not having the address bar selected on CTRL + T, but it was actually an issue with non-persistent background script getting started (from Innactive to Active) and then using internal chrome.tabs.update. That problem occured only in OSX and Windows. In Chrome OS, it all worked well. Adding autofocus back, with a better implementation this time, using selection and range.
Sidebar: - Show by default - Toggle with CMD+S (remember on next visit) - Resize with mouse (reset on double click) Toolbar: - Show by default - Toggle with CMD+E (remember on next visit) Esc: - Close Modal using Cancel Options: - Update Hotkeys Themes: - Add shared.css - Add light.css - Add dark.css - Improve set-theme.js
- Update "customTheme" migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Sidebar (Closes Sidebar #95) and simplified design (removed page with note previews, having 1 page only)
Themes are decoupled (can be easily interchanged) and Custom theme customization is improved (Closes Decouple Themes, improve Custom theme customization #107, Closes Unable to paste Hex code while setting background color in custom theme option #104)
Added new Hotkeys (Toggle Sidebar, Toggle Toolbar, Open note on mouse hover, Close context menu, Close modal, Confirm modal), see Options
Context menu (before Dropdown) is hidden on a click outside (Closes Close dropdowns on click outside #109)
The cursor position (or selection) in the note is restored after the Context menu or Modal, is closed (Closes Restore cursor position on any modal closed #106)
Image is inserted at the cursor position (Closes Image doesn't get added to the position of the cursor #103), and the image saving is fixed (Closes Image inserted by the URL doesn't get saved if it's the last change in the note #108)