util: add fiemap fallback for errno ENOTTY #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this is on WSL 1, not 2.
This is misleading: this only happen on WSL-1, not on a well-behaved system, so a better phrasing would be: No, I am not sure this is a good idea to add this workaround, because ENOTTY Also, is supporting WSL-1 a good idea, when it is known to have quite some |
|
The patch quite simple, so I think it's acceptable in general, but the commit message should be modified as suggested. |
On WSL-1, genimage fails with (see [1] for details): ERROR: hdimage(sdcard.img): fiemap .../boot.vfat: 25 Inappropriate ioctl for device This is because WSL-1 is a limited Linux emulation layer, where the fiemap ioctl incorrectly returns ENOTTY instead of the expected EOPNOTSUPP. [1] https://bugs.busybox.net/show_bug.cgi?id=13146 Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Changes v1 -> v2: - improved commit message (according to suggestion by Yann E. MORIN)
pseiderer
force-pushed
the
ps-devel-genimage-ubuntu-20.04.1-wsl-001
branch
from
437a318
to
4c2b02d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using genimage (for buildroot) on Ubuntu-20.04.1 on WSL fails
with (see [1] for details):
ERROR: hdimage(sdcard.img): fiemap .../buildroot-2020.08-rc1/images/boot.vfat: 25 Inappropriate ioctl for device
This is because the fiemap ioctl sets errno to ENOTTY instead of the
expected EOPNOTSUPP.
[1] https://bugs.busybox.net/show_bug.cgi?id=13146
Signed-off-by: Peter Seiderer ps.report@gmx.net