bootspec.bbclass: Refactoring, Fixes and Documentation #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to use d.expand() for a single variable. Align it with the other d.getVar() calls. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Otherwise, changes to these will not trigger rebuilds and thus the result will not end up in the generated rootfs. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
It will be used in for loop only and always gets a value assigned there. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Make it a python method that can be called from the variable assignment instead of using anonymous python with an intermediate variable. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Emantor
approved these changes
Jun 7, 2024
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vardeps]to fix rebuilds when changingBOOTSPEC_optionsBOOTSPEC_OPTIONSdefault