Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block fold button on mobile #90

Open
Bad3r opened this issue Mar 19, 2023 · 5 comments · Fixed by #94
Open

block fold button on mobile #90

Bad3r opened this issue Mar 19, 2023 · 5 comments · Fixed by #94
Labels
help wanted Extra attention is needed

Comments

@Bad3r
Copy link

Bad3r commented Mar 19, 2023

Looks like logseq moved the block fold button from left to right on mobile devices:
Dev theme:
image

Logseq default theme:
image

This seems to be a recent change. I can't find the PR or commit, though.
It might be related to the following:
https://github.com/logseq/logseq/blob/2ca70373af6b7ef9b94df074d0caac3ea99bd849/src/main/frontend/components/theme.css#L117

CC: @UNICKCHENG

@Bad3r
Copy link
Author

Bad3r commented Mar 19, 2023

I think its related to these classes?

.block-control .control-hide,
.block-control:hover .control-hide {
  display: flex;
}

main.ls-fold-button-on-right #main-content-container {
  padding-left: 18px;
  padding-right: 18px;
  padding-top: 4px;
}

main.ls-fold-button-on-right .ls-block .block-control:active {
  opacity: 1;
}

main.ls-fold-button-on-right
  .ls-block
  .block-control
  .rotating-arrow.collapsed
  svg {
  transform: rotate(180deg);
}

main.ls-fold-button-on-right .ls-block[haschild="true"] .control-hide {
  display: block !important;
}

main.ls-fold-button-on-right .ls-block .block-content-wrapper {
  width: 100%;
}

main.ls-fold-button-on-right .block-children-container {
  margin-left: 7px;
}

main.ls-fold-button-on-right .block-children-container .block-children {
  padding-left: 10px;
}

main.ls-fold-button-on-right .ls-block[haschild="true"] .control-hide {
  display: block !important;
}

main.ls-fold-button-on-right
  .ls-block
  .block-control
  .rotating-arrow.collapsed
  svg {
  transform: rotate(180deg);
}

main.ls-fold-button-on-right .ls-block .block-control {
  position: absolute;
  right: -0.75rem;
  top: 0px;
  z-index: 1;
  padding-right: 0.5rem;
  padding-top: 0.25rem;
  opacity: 0.2;
}

@UNICKCHENG
Copy link
Collaborator

Looks like logseq moved the block fold button from left to right on mobile devices:

Dev theme:

image

Logseq default theme:

image

This seems to be a recent change. I can't find the PR or commit, though.

It might be related to the following:

https://github.com/logseq/logseq/blob/2ca70373af6b7ef9b94df074d0caac3ea99bd849/src/main/frontend/components/theme.css#L117

CC: @UNICKCHENG

sure, it was already mentioned in a previous issue, and at that time I thought it didn't seriously affect the interaction, so I didn't submit PR. See #86

I will try to fix this issue in the next few days.

@Bad3r
Copy link
Author

Bad3r commented Mar 20, 2023

@UNICKCHENG sorry for the duplicate report. This is a significant complaint for multiple users. It prevents the functionality of being able to focus on a block. I have attempted to figure out a solution without any luck so far. I am not sure what is overwriting it.

@UNICKCHENG
Copy link
Collaborator

@Bad3r I made some simple attempts, which also seemed to fail. I'll try to solve it later.

@UNICKCHENG UNICKCHENG added the help wanted Extra attention is needed label Mar 21, 2023
UNICKCHENG added a commit that referenced this issue May 13, 2023
fix: fix block fold button on mobile

CLOSE #86 #90
@UNICKCHENG
Copy link
Collaborator

#94: no success, unless the following code is removed. However, removing the code will cause the bullet threading to fail.

.ls-block div.items-center {
  position: relative;
  height: 26px !important;
}

image

@UNICKCHENG UNICKCHENG reopened this May 13, 2023
UNICKCHENG added a commit to UNICKCHENG/logseq-developer-theme that referenced this issue May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants