bullet_threading: broke line drawing error #95

cybertosher · 2023-05-15T14:14:20Z

After the latest update there are small vertical lines that do not line up properly on Windows 10 machine. This was not the case on Friday, so I assume it is the latest commit to fix items on mobile platforms that did it.

UNICKCHENG · 2023-05-15T14:41:27Z

@cybertosher I'm sorry for causing you trouble. The main reason is that Logseq was recently updated to version 0.9.6, which caused compatibility issue(#92). This issue seems to have been fixed before(#93), but it still appears in your screenshot. Could you please try the following steps to check again?

update logseq-dev-theme to the latest version, v1.26.17.
check if there are any additional configurations in the logseq/custom.css file.

UNICKCHENG · 2023-05-15T14:56:51Z

If you find this issue still exists, you can try adding the following code to logseq/custom.css and adjusting the value of "left" to fix it.

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

cybertosher · 2023-05-16T14:44:40Z

Greeting! None of these worked for me. I was not using the logseq-dev-theme, I was using Bonofix before this issue started. What I tried was this:

I downloaded the latest dev theme (1.26.17) and verified that the custom.css file was empty. No change.
I selected the dev theme as my active theme, no change.
I added the custom css code above and no change
I deleted Bonofix and ensured that dev theme was the only theme installed, no change
Restarted logseq several times, no change.

So unfortunately I still have the issue with threading not working, but the additional distraction of a theme I don't like as much. 😄 Any ideas when or if this will be fixed, or something else I can try?

Thanks for all of your efforts.

MaxenceG2M · 2023-05-16T15:08:40Z

Hi!

I have the same problem, but the @UNICKCHENG fix works for me with a really huge value (e.g. -500).

There is a screenshot with a value of -200:

The last really deep bullets bring back the problem.

HtH

By the way, thank you for your work on this great plugin, one of the most essential for me :)

cybertosher · 2023-05-16T15:18:39Z

I tried the custom.css code with -250px as the offset, as @MaxenceG2M suggested, and it cleans up the issue for the bullet levels I use. I'm OK with weird artifacts that only happen sometimes.

And I agree, thanks for all of your work @UNICKCHENG on this plugin, it is definitely my favorite.

Vitor12xx · 2023-05-18T15:04:19Z

I was able to use @UNICKCHENG fix to align the rogue vertical line with -16px as the offset.

Thanks for the fix!

cybertosher · 2023-05-19T05:08:18Z

Is there going to be a permanent fix anytime soon? Changing my custom.css to -15px solved the issue on my Mac, but this workaround seems a bit arbitrary. Just curious. 😃

UNICKCHENG · 2023-05-19T07:50:06Z

Is there going to be a permanent fix anytime soon? Changing my custom.css to -15px solved the issue on my Mac, but this workaround seems a bit arbitrary. Just curious. 😃

A more universal solution than this one cannot be found at present, but I believe that this issue will eventually be resolved in the future.

schmy · 2023-05-21T00:41:23Z

Sorry to trouble you with this minor query, but could you please identify which line in the CSS describes the horizontal line for the child?

I have already amended the line mentioned above ("ls-block ... -21 px"), but I cannot work out which other line draws to the dot point of the child lines.

Thanks in advance!

ericz15 · 2023-05-21T02:08:14Z

Hi, I encountered the same issue and wanted to share my custom.css file:

@import url("https://cdn.jsdelivr.net/gh/sokirill/logseq-panic-theme@main/custom.css");

:root {
    --ct-code-font-family: Maple Mono, Fira Code, Monaco, Menlo, Consolas, 'COURIER NEW', "等距更纱黑体 SC", monospace;
    --ls-font-family: Verdana, 'fira sans', 'segoe UI Emoji', 'sarasa ui sc', sans-serif;
}

#root>div,
html,
body {
    font-family: var(--ls-font-family);
}

:not(pre)>code,
.CodeMirror {
    font-family: var(--ct-code-font-family);
}

I've tried the solution mentioned earlier with left: -21px;, but unfortunately, the issue still persists.

Thank you for your attention to this matter.

Update: I tried left: -15px;, and it works for me.

ginko-ai · 2023-05-21T15:45:32Z

I have similar issue, (luv the plug-in btw)

UNICKCHENG · 2023-05-22T01:39:39Z

Sorry to trouble you with this minor query, but could you please identify which line in the CSS describes the horizontal line for the child?

I have already amended the line mentioned above ("ls-block ... -21 px"), but I cannot work out which other line draws to the dot point of the child lines.

Thanks in advance!

@schmy Try modifying the value of "right" like right: 50px ?

.ls-block > div > div.items-center::before {
    right: 10px !important;
}

UNICKCHENG · 2023-05-22T01:50:07Z

I have similar issue, (luv the plug-in btw)

@ginko-ai , the issue appearing in your screenshot seems to be related to the CSS configuration of the plugin being overridden, which is causing it not to work correctly. Please refer to the following method for troubleshooting.

update logseq-dev-theme to the latest version, v1.26.17.
check if there are any additional configurations in the logseq/custom.css file.

cybertosher · 2023-05-22T19:11:37Z

Just an update: for some reason my logseq at work does not automatically update. I manually updated to logseq version 0.9.6, applied the -21px offset in custom.css and now everything draws correctly.

whZhang1 · 2023-06-03T13:54:02Z

I have similar issue, (luv the plug-in btw)

I have the same quesiton and how to solve this?

UNICKCHENG · 2023-06-03T16:18:51Z

I have similar issue, (luv the plug-in btw)

@ginko-ai , the issue appearing in your screenshot seems to be related to the CSS configuration of the plugin being overridden, which is causing it not to work correctly. Please refer to the following method for troubleshooting.

update logseq-dev-theme to the latest version, v1.26.17.

check if there are any additional configurations in the logseq/custom.css file.

@Zhangwuhao here ? If there are still errors, could you provide screenshots and configuration information?

Strubbl · 2023-06-16T12:34:51Z

I have a similar issue:

I have no content in logseq/custom.css. This issue was fixed for me, when i installed the plugin Bullet threading. So i can reproduce the issue by deactivating that plugin.

reprintsev · 2023-06-24T16:47:01Z

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.

Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears.

I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

DreamWaterFound · 2023-06-26T07:36:16Z

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.

Adding this code to the custom.css did not help
.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}
but if I change the value of the left from -21px to -13px then the problem disappears.

I don't know how correct this is, but I did it and it works:
.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

Thanks! I also have tried to adjust the left offset but seems bad. This is work for me. Do not display the vertical dash is work for me.

DreamWaterFound · 2023-06-26T08:05:44Z

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.
Adding this code to the custom.css did not help
.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}
but if I change the value of the left from -21px to -13px then the problem disappears.
I don't know how correct this is, but I did it and it works:
.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}
Thanks! I also have tried to adjust the left offset but seems bad. This is work for me. Do not display the vertical dash is work for me.

Sorry, I need to apologize for my arbitrary conclusion. The method above eliminates the display of vertical lines, which exposes an issue on pages with title text. Below is the erroneous display with vertical lines:

Whereas the following is the result with the vertical lines removed:

So in the end, I still need to adjust the left offset. At the same time, I noticed an issue with the curve and bullet points not aligning closely. Thanks to @UNICKCHENG, I referred to this reply and used the following code in logseq/custom.css to achieve a nearly perfect effect:

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -13px;
}
.ls-block > div > div.items-center::before {
    right: 10px !important;
}

I hope my experience is helpful to someone.

OS: ubuntu 20.04
Logseq: 0.9.9
logseq-dev-theme: 1.26.17

UdeRecife · 2023-07-23T09:13:16Z

EDIT:
I managed to solve the issue by tweaking the value even further.

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -13.8px;
}

cybertosher · 2024-03-17T19:00:25Z

Broken again. I have logseq 0.10.7 and the latest dev theme, and once again there is a little broken line. No configuration in custom.css. Is the best way to fix this one again to add the custom CSS, or is there an error with the theme maybe that fixes it? I do not have this issue on Windows 10, only MacOS. This is kind of like Whack-A-Mole

OK, so today I learned (I am slow like this) that the dev theme has bullet threading built in, and that I need to use the dev-theme without bullet threading along with the bullet threading plugin. When I do that, I do not have the little extra bit. So the theme is broken, not the plugin. Closing as my bad.

cybertosher · 2024-03-17T19:25:01Z

The plugin seems to be working fine, my issue is with the theme.

UNICKCHENG changed the title ~~Latest update broke line drawing~~ bullet_threading: broke line drawing error May 29, 2023

UNICKCHENG pinned this issue May 29, 2023

GuessWhatBBQ mentioned this issue Jun 27, 2023

Bullet threads not properly aligned kirso/logseq-panic-theme#9

Open

mazshakibaii mentioned this issue Oct 2, 2023

As shown in the picture, why is there an additional short vertical line here? #100

Open

cybertosher closed this as completed Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bullet_threading: broke line drawing error #95

bullet_threading: broke line drawing error #95

cybertosher commented May 15, 2023

UNICKCHENG commented May 15, 2023 •

edited

Loading

UNICKCHENG commented May 15, 2023

cybertosher commented May 16, 2023 •

edited

Loading

MaxenceG2M commented May 16, 2023 •

edited

Loading

cybertosher commented May 16, 2023 •

edited

Loading

Vitor12xx commented May 18, 2023 •

edited

Loading

cybertosher commented May 19, 2023 •

edited

Loading

UNICKCHENG commented May 19, 2023

schmy commented May 21, 2023

ericz15 commented May 21, 2023 •

edited

Loading

ginko-ai commented May 21, 2023

UNICKCHENG commented May 22, 2023

UNICKCHENG commented May 22, 2023 •

edited

Loading

cybertosher commented May 22, 2023 •

edited

Loading

whZhang1 commented Jun 3, 2023

UNICKCHENG commented Jun 3, 2023 •

edited

Loading

Strubbl commented Jun 16, 2023

reprintsev commented Jun 24, 2023

DreamWaterFound commented Jun 26, 2023

DreamWaterFound commented Jun 26, 2023

UdeRecife commented Jul 23, 2023 •

edited

Loading

cybertosher commented Mar 17, 2024 •

edited

Loading

cybertosher commented Mar 17, 2024

bullet_threading: broke line drawing error #95

bullet_threading: broke line drawing error #95

Comments

cybertosher commented May 15, 2023

UNICKCHENG commented May 15, 2023 • edited Loading

UNICKCHENG commented May 15, 2023

cybertosher commented May 16, 2023 • edited Loading

MaxenceG2M commented May 16, 2023 • edited Loading

cybertosher commented May 16, 2023 • edited Loading

Vitor12xx commented May 18, 2023 • edited Loading

cybertosher commented May 19, 2023 • edited Loading

UNICKCHENG commented May 19, 2023

schmy commented May 21, 2023

ericz15 commented May 21, 2023 • edited Loading

ginko-ai commented May 21, 2023

UNICKCHENG commented May 22, 2023

UNICKCHENG commented May 22, 2023 • edited Loading

cybertosher commented May 22, 2023 • edited Loading

whZhang1 commented Jun 3, 2023

UNICKCHENG commented Jun 3, 2023 • edited Loading

Strubbl commented Jun 16, 2023

reprintsev commented Jun 24, 2023

DreamWaterFound commented Jun 26, 2023

DreamWaterFound commented Jun 26, 2023

UdeRecife commented Jul 23, 2023 • edited Loading

cybertosher commented Mar 17, 2024 • edited Loading

cybertosher commented Mar 17, 2024

UNICKCHENG commented May 15, 2023 •

edited

Loading

cybertosher commented May 16, 2023 •

edited

Loading

MaxenceG2M commented May 16, 2023 •

edited

Loading

cybertosher commented May 16, 2023 •

edited

Loading

Vitor12xx commented May 18, 2023 •

edited

Loading

cybertosher commented May 19, 2023 •

edited

Loading

ericz15 commented May 21, 2023 •

edited

Loading

UNICKCHENG commented May 22, 2023 •

edited

Loading

cybertosher commented May 22, 2023 •

edited

Loading

UNICKCHENG commented Jun 3, 2023 •

edited

Loading

UdeRecife commented Jul 23, 2023 •

edited

Loading

cybertosher commented Mar 17, 2024 •

edited

Loading