Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: opening a new tab from favorites in sidebar #74

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: opening a new tab from favorites in sidebar #74

merged 1 commit into from
Feb 17, 2023

Conversation

dansseg
Copy link
Contributor

@dansseg dansseg commented Feb 15, 2023 •
edited
Loading

Hi,
I've implemented two things:

  • opening a new tab is now also possible from favorites or recent files (closes #68)
  • middle mouse button click on a page ref will no longer start scrolling

@dansseg
- opening a new tab is now also possible from favorites or recent files
13f060a 
- middle mouse button click on a page ref will no longer start scrolling
@pengx17 pengx17 changed the title Opening a new tab from favorites in sidebar feat: opening a new tab from favorites in sidebar Feb 16, 2023
@pengx17 pengx17 changed the title feat: opening a new tab from favorites in sidebar fix: opening a new tab from favorites in sidebar Feb 16, 2023
pengx17
pengx17 reviewed Feb 16, 2023
View reviewed changes
src/PageTabs.tsx
@@ -276,6 +288,7 @@ function getBlockUUID(element: HTMLElement) {
function stop(e: Event) {
e.stopPropagation();
e.stopImmediatePropagation();
e.preventDefault(); // prevent scrolling from middle mouse button click
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it also stop scrolling with wheel event?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean? If it is also stopping the normal scroll wheel event (not from the middle mouse button)?
The stop method is only called on middle mouse button click or on Ctrl + left mouse button click.

@pengx17
Copy link
Owner

pengx17 commented Feb 16, 2023

Please use semantic commit messages that start with fix: or feat: . Otherwise the github action will ignore the commit and not issue new releases.

@dansseg
Copy link
Contributor Author

dansseg commented Feb 17, 2023

Please use semantic commit messages that start with fix: or feat: . Otherwise the github action will ignore the commit and not issue new releases.

sorry, I was not aware. First pull request...

@pengx17
Copy link
Owner

pengx17 commented Feb 17, 2023

@dansseg I am merging the pr. If no new release is being created, I will cut one manually.

@pengx17 pengx17 merged commit ca472d8 into pengx17:master Feb 17, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.18.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengx17 pengx17 pengx17 left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening a new tab from favorites in sidebar
2 participants
@dansseg @pengx17