Social login existing if related user exists

[pannkotsky]

Hey.
After library upgrade I have a broken social login because of the following pieces of code:
https://github.com/pennersr/django-allauth/blob/main/allauth/socialaccount/models.py#L276-L283
https://github.com/pennersr/django-allauth/blob/main/allauth/socialaccount/helpers.py#L208-L209

The latter assertion fails in my app on login.

Can someone tell why social login instance is considered existing if there is a related user in the database? How the existing users are supposed to login then?

In the library version I had before is_existing property on SocialLogin only checks if account has pk.

Thanks

[pannkotsky]

This must be an issue reported by another user #3679

[pennersr]

The code performing the assert not sociallogin.is_existing is the start of the flow that signs in, or signs up users authenticating via a provider. At that point, no lookup has been done yet -- or better: should have been done yet -- about whether that sociallogin is in fact an existing user, or a new user signing up. If that assert fires in your case, that suggests something is wrong. You may have a signal/adapter/hook somewhere performing unexpected behavior.

[pannkotsky]

@pennersr thank you for the response. in my case this line of code returns a SocialLogin instance with a user already attached
https://github.com/pennersr/django-allauth/blob/main/allauth/socialaccount/providers/oauth2/views.py#L160-L162

I use standard Google and LinkedIn providers, so it doesn't seem like my customizations has anything to do with it

[pennersr]

Having a user instance attached is fine, but its pk should not be set / pointing to an existing user. The user instance originates from this piece of code:

https://github.com/pennersr/django-allauth/blob/main/allauth/socialaccount/providers/base/provider.py#L96

As you can see, a new_user() is instantiated there, which is not backed yet by a database record.

[pannkotsky]

@pennersr thanks. our adapter indeed returns a saved user instance in new_user method. it contains our custom logic for finding existing user and other things

[pennersr]

I suggest you move that logic to the pre_social_login() adapter method. The new_user() method is really meant to do just that -- instantiate a blank new user instance, and only fill in some defaults if needed.