Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Use module-level __getattr__ instead of sys.modules hack #3344

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Settings: Use module-level __getattr__ instead of sys.modules hack #3344

merged 1 commit into from
Jul 12, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Jul 12, 2023

Module-level __getattr__ is supported since Python 3.7.

@coveralls
Copy link

Coverage Status

coverage: 91.299% (-0.002%) from 91.301% when pulling 35fa20d on akx:settings into f797b5e on pennersr:main.

@akx akx marked this pull request as ready for review July 12, 2023 09:55
@pennersr pennersr merged commit 68dd4c5 into pennersr:main Jul 12, 2023
23 of 24 checks passed
@akx akx deleted the settings branch July 12, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akx @coveralls @pennersr