Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yandex): moved oauth token from params to headers (security issue… #3349

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

Mortie1
Copy link
Contributor

@Mortie1 Mortie1 commented Jul 15, 2023

…s: https://yandex.ru/dev/id/doc/en/user-information)

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers.rst.
  • Add an entry to the list of supported providers over at docs/overview.rst.

@coveralls
Copy link

coveralls commented Jul 15, 2023

Coverage Status

coverage: 91.607% (+0.2%) from 91.376% when pulling 631ea95 on Mortie1:fix-insecure-request-yandex-provider into fc772f2 on pennersr:main.

@pennersr
Copy link
Owner

Can you make sure the views.py changes are properly formatted according to black? Thanks.

@Mortie1 Mortie1 force-pushed the fix-insecure-request-yandex-provider branch 2 times, most recently from f5a4b9c to 4dd53da Compare July 16, 2023 11:23
@Mortie1 Mortie1 force-pushed the fix-insecure-request-yandex-provider branch from 4dd53da to 631ea95 Compare July 16, 2023 11:24
@pennersr pennersr merged commit cc77913 into pennersr:main Jul 17, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants