Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(socialaccount): Allow new sociallogin accounts to establish SITE_ID from request #3548

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jeredfloyd
Copy link
Contributor

Commit be779df broke the ability to create new sociallogin accounts in Mailman3 when using django sites framwork, because the request object is not passed down the call chain. This eventually results in the error:

Exception Type: ImproperlyConfigured at /accounts/google/login/callback/
Exception Value: You're using the Django "sites framework" without having set the SITE_ID setting. Create a site in your database and set the SITE_ID setting or pass a request to Site.objects.get_current() to fix this error.

This patch (optionally) passes the request object to resolve this issue.

@coveralls
Copy link

Coverage Status

coverage: 95.785%. remained the same
when pulling 0278e80 on jeredfloyd:fix-site-id
into 1a8b67d on pennersr:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants