Custom account email verification through adapter #1946

[muneeb706]

Submitting Pull Requests

General

• Make sure you use semantic commit messages.
  Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
• All Python code must formatted using Black, and clean from pep8 and isort issues.
• JavaScript code should adhere to StandardJS.
• If your changes are significant, please update ChangeLog.rst.
• If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

N/A

• Make sure unit tests are available.
• Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
• Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
• Add an entry to the list of supported providers over at docs/overview.rst.

[muneeb706]

How can I get user's email in this method to pass it to get_email_verification_method ?

[pennersr]

This method is called to get a list of scopes to ask permission for as part of the OAuth handshake. So, at this point in time you do not know what user is going to be authenticated, yet.

[pennersr]

Suggested change

	def get_email_verification_method(self, email=None):
	def get_email_verification_method(self, login):

Now that we have a Login class representing the current login, I think it is more useful to base this method on an instance of that. See:

https://github.com/pennersr/django-allauth/blob/main/allauth/account/utils.py#L158

So, for that to happen, I think we need to:

• For every case where the default value (email_verification=app_settings.EMAIL_VERIFICATION) is passed, pass None. Then, inside the __init__ of Login, when the email verification is not explicitly set to a value, call this adapter method.

[muneeb706]

Thank you for reviewing I'll work on it.

[muneeb706]

In assess_unique_email method https://github.com/pennersr/django-allauth/blob/main/allauth/account/utils.py#L496

We only have access to email not the Login instance as it is called before we complete signup.
Is it a good idea to keep both login and email ? or login can be None in this scenario ?

[coveralls]

coverage: 95.698% (+0.02%) from 95.683%
when pulling 3d9a847 on muneeb706:feature_1946-customizable-account-email-verification
into fac8b9a on pennersr:main.