Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin.rst #3872

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Update admin.rst #3872

merged 1 commit into from
Jun 11, 2024

Conversation

JonSpeare
Copy link
Contributor

@JonSpeare JonSpeare commented Jun 7, 2024

It was unclear to me and would have made the instructions easier to follow.

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

It was unclear to me and would have made the instructions easier to follow.
@pennersr pennersr merged commit 38eb311 into pennersr:main Jun 11, 2024
57 checks passed
@coveralls
Copy link

Coverage Status

coverage: 95.708%. remained the same
when pulling 8d46031 on JonSpeare:patch-1
into f6577fa on pennersr:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants