Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Option to require authentication #2

Merged
merged 1 commit into from
Oct 13, 2020
Merged

feat: Option to require authentication #2

merged 1 commit into from
Oct 13, 2020
+72 −21

Conversation

Ecno92
Copy link
Contributor

@Ecno92 Ecno92 commented Oct 13, 2020

Fixes #1 and adds an optional HEALTHPOINT_AUTH_REQUIRED setting.

When the setting is set to True it ensures that the healthchecks are only executed when the correct authentication is used. (Either basic auth or staff member/superuser)

@coveralls
Copy link

Coverage Status

Coverage increased (+4.8%) to 96.403% when pulling 548a5a4 on Ecno92:feature/optional-require-auth into 8d1853e on pennersr:master.

@Ecno92 Ecno92 changed the title feat: Option to require basic authentication feat: Option to require authentication Oct 13, 2020
@pennersr pennersr merged commit 4d04b41 into pennersr:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential Denial of Service vunerability
3 participants
@Ecno92 @coveralls @pennersr