Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request variable shadowing #12

Merged
merged 2 commits into from Dec 20, 2019
Merged

Fix request variable shadowing #12

merged 2 commits into from Dec 20, 2019

Conversation

ezwang
Copy link
Member

@ezwang ezwang commented Dec 20, 2019

The response returned by the platform request overwrites the original request variable, which is needed when you do the authenticate and login calls.

This throws an AttributeError when you do auth.login because responses don't have session information.

@ezwang ezwang requested a review from ArmaanT December 20, 2019 16:11
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 732fbee on typo-fix into 9d7e43d on master.

@ArmaanT ArmaanT merged commit a444d3d into master Dec 20, 2019
@ArmaanT ArmaanT deleted the typo-fix branch December 20, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmaanT ArmaanT ArmaanT approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezwang @coveralls @ArmaanT