Ticketing

[rohangpta]

Mega PR for Ticketing project

Ticket administrators

• Create initial ticket offerings (PUT api/events/<event_id>/tickets) (idempotency/editable)
• View individual ticket information (for confirmation page) (GET api/ticket/<ticket_id>)
• Generate QR code for ticket with link to confirmation page (GET api/ticket/<ticket_id>/qr)
• View ticket counters (available, totals) and buyers (GET api/events/<event_id>/tickets). Buyers are viewable only by officers of club. (GET api/events/<event_id>/buyers).

Ticket buyers

• Atomic add to cart (POST api/events/<event_id>/add_to_cart)
• List owned tickets (GET api/tickets)
• Atomic remove from cart (POST api/events/<event_id>/remove_from_cart)
• Atomic checkout (initiate 10 minute hold on tickets in cart) (POST api/tickets/checkout)
• View and validate cart (try to replace ticket instances that have been sold out). (GET api/tickets/cart)
• Ticket buy callback (update ownership, send confirmation email (POST api/tickets/buy)

Misc

• Payment integration
• Update populate script
• Attendance tracking
• Mobile-friendly improvements
• Consistency and load testing

[codecov]

Codecov Report

Attention: Patch coverage is 91.50943% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 71.00%. Comparing base (d199a7e) to head (e1fac0b).
Report is 8 commits behind head on master.

Files	Patch %	Lines
...s/management/commands/expire_membership_invites.py	33.33%	2 Missing ⚠️
...nd/clubs/management/commands/update_club_counts.py	33.33%	2 Missing ⚠️
backend/clubs/serializers.py	84.61%	2 Missing ⚠️
...nd/clubs/management/commands/find_broken_images.py	50.00%	1 Missing ⚠️
backend/clubs/models.py	98.41%	1 Missing ⚠️
backend/clubs/permissions.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   69.78%   71.00%   +1.21%     
==========================================
  Files          31       31              
  Lines        6387     6804     +417     
==========================================
+ Hits         4457     4831     +374     
- Misses       1930     1973      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cphalen]

All gas no breaks. Well done Rohan!

[cphalen]

Buyers probably shouldn't be public because we don't want everyone to know who owns tickets. I don't think it's a huge deal but would be weird if I could like track you down and know for certain that you're doing to show. Maybe just show the user their own tickets or something? I like totals and available though.

[cphalen]

Never mind, my bad I didn't realize this viewset had a permission class — this is perfect!

[gitguardian]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10282361	Triggered	Generic High Entropy Secret	428dd7e	backend/pennclubs/settings/development.py	View secret
9451515	Triggered	Generic Password	50b9c0b	.github/workflows/cdkactions_build-and-deploy.yaml	View secret
9451515	Triggered	Generic Password	03214af	.github/workflows/cdkactions_build-and-deploy.yaml	View secret
9451515	Triggered	Generic Password	80e8201	.github/workflows/cdkactions_build-and-deploy.yaml	View secret
10282361	Triggered	Generic High Entropy Secret	40fb7f7	backend/pennclubs/settings/ci.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>