Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted deprecated QuestionResponse model and removed duplicate line (rank field in Club model) #625

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Deleted deprecated QuestionResponse model and removed duplicate line (rank field in Club model) #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd1880b
Remove deprecated QuestionResponse model
Porcupine1 Mar 5, 2024
e8965fd
remove duplicate line: 'rank field in Club'
Porcupine1 Mar 5, 2024
2bd36b1
made migrations after deleting QuestionResponse
Porcupine1 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions backend/clubs/migrations/0096_delete_questionresponse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Generated by Django 5.0.2 on 2024-03-06 01:23

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("clubs", "0095_rm_field_add_count"),
]

operations = [
migrations.DeleteModel(
name="QuestionResponse",
),
]
12 changes: 0 additions & 12 deletions backend/clubs/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,6 @@ class Club(models.Model):
# cache club rankings
rank = models.IntegerField(default=0)

# cache club rankings
rank = models.IntegerField(default=0)

created_at = models.DateTimeField(auto_now_add=True)
updated_at = models.DateTimeField(auto_now=True)

Expand Down Expand Up @@ -1776,15 +1773,6 @@ class Meta:
unique_together = (("question", "submission"),)


class QuestionResponse(models.Model):
"""
Represents a response to a question on a custom application
"""

question = models.ForeignKey(ApplicationQuestion, on_delete=models.CASCADE)
response = models.TextField(blank=True)


@receiver(models.signals.pre_delete, sender=Asset)
def asset_delete_cleanup(sender, instance, **kwargs):
if instance.file:
Expand Down
Loading