Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add under construction site for PCP/PCS #28

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Conversation

davish
Copy link
Member

@davish davish commented Oct 1, 2019

This PR is step 1 in shutting down the current version of PCS. We'll redirect to an "under construction" page similar to Penn Clubs:

Screen Shot 2019-10-01 at 9 36 54 AM

@davish davish requested a review from ArmaanT October 1, 2019 13:38
Copy link
Member

@dlike230 dlike230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the fact that the CSS in the style tag isn't indented

@eyingxuan
Copy link
Contributor

Frontend lgtm! Not too sure how Django works, but should we comment out the other paths after the root url match in urls.py?

@davish
Copy link
Member Author

davish commented Oct 1, 2019

Frontend lgtm! Not too sure how Django works, but should we comment out the other paths after the root url match in urls.py?

I think it should be fine. Only thing is that means that people snooping around will be able to see our representation of course data, which they could access anyway through api.pennlabs.org.

@davish davish merged commit 0be8cb6 into master Oct 1, 2019
@davish davish deleted the pcs-underconstruction branch October 1, 2019 14:03
AaDalal added a commit that referenced this pull request Apr 3, 2024
Add login and hook up degreeplans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants