Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Shortener to PyPi #33

Merged
merged 4 commits into from
Oct 11, 2019
Merged

Migrate Shortener to PyPi #33

merged 4 commits into from
Oct 11, 2019

Conversation

ArmaanT
Copy link
Member

@ArmaanT ArmaanT commented Oct 9, 2019

This PR transitions from including shortener in the repo to installing it from pypi.

@ArmaanT ArmaanT requested a review from davish October 9, 2019 01:58
davish
davish approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@davish davish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! gotta love reusability

@davish davish merged commit ae2bb43 into master Oct 11, 2019
@davish davish deleted the fix/shortener branch October 11, 2019 22:44
AaDalal added a commit that referenced this pull request Apr 3, 2024
@AaDalal
Merge pull request #33 from pennlabs/aag/fulfillments-frontend
6300f52 
Add fulfillments to frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davish davish davish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArmaanT @davish