Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Logic #35

Merged
merged 26 commits into from
Oct 19, 2019
Merged

Filter Logic #35

merged 26 commits into from
Oct 19, 2019

Conversation

eyingxuan
Copy link
Contributor

@eyingxuan eyingxuan commented Oct 12, 2019 •
edited

This PR adds logic for searching with filters. Note that filter-related reducers have been moved to a separate file.

  • Searching with school requirements
  • Changed difficulty, quality, time and CU filters into sliders
  • Searching with difficulty, quality, time and CU
  • Implement clear all button
  • Implement stateful filter buttons
  • Fix Lint Errors

@eyingxuan eyingxuan self-assigned this Oct 12, 2019
@davish
Copy link
Member

davish commented Oct 12, 2019

Filter Component

eyingxuan and others added 15 commits October 12, 2019 22:01
@eyingxuan
Modified search logic to allow for instant search
006baa8
@eyingxuan
Added slider functionality and logic for difficulty filtering
d9b983a
@eyingxuan
Added slider functionality and logic for all range filters
41a5b84
@eyingxuan
Patched names for courseq and instructorq
53c3da2
@eyingxuan
Changed lower bound for cu
72cc276
@eyingxuan
Added clear all functionality, changed filters to search automaticall…
f5e75c1 
…y after 200ms
@davish
Merge branch 'master' into filter-logic
526e429
@davish
fixed vulnerabilities
8541fec
@davish
should fix searching
fc6373a
@eyingxuan
made query to api shorter depending on default filters
4a4a409
@eyingxuan
Added x button for filters (misaligned)
0d133f2
@eyingxuan
implemented clear filters for independent filters
18591ef
@eyingxuan
modified reducers for clearing filters, implemented search on clear
9d72b02
@eyingxuan
Modified clear all to not clear string, implemented search on clear all
1829e6a
@eyingxuan
fix lints
c2799af
@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.745% when pulling 2f9d2b3 on filter-logic into 9f275d9 on master.

@davish davish merged commit c2ec16e into master Oct 19, 2019
@davish davish deleted the filter-logic branch October 19, 2019 20:04
AaDalal pushed a commit that referenced this pull request Apr 3, 2024
@yuntongf
Merge pull request #35 from pennlabs/aag/cleanup
43864dd 
Make requirements panel DND sync with fulfillments state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davish davish davish approved these changes

Assignees

@eyingxuan eyingxuan

Labels
do not merge frontend
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyingxuan @davish @coveralls