This repository has been archived by the owner on Jul 7, 2022. It is now read-only.
Replace TermColors class with termcolor and colorama modules #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request doesn't follow our guidelines. Please fix the following:
Click here for details. Thank you! 🙏 |
jasonwalsh
suggested changes
Dec 11, 2017
aptos/__main__.py
Outdated
| from .parser import SchemaParser | ||
| from .primitive import Object | ||
| from .visitor import ValidationVisitor | ||
| from .schema.visitor import AvroSchemaVisitor | ||
|
|
||
|
|
||
| ''' previous color solution, not working in Windows | ||
| class TermColors: |
There was a problem hiding this comment.
You can remove the TermColors class since it is not being used anymore.
|
@TheWindRider thanks for your PR! I left some feedback. Also, take a look at the build status as it appears to be failing the flake8 style linting checks. Once the build succeeds, I'll merge it into master. |
|
Took a closer look, and now I understand why it's failing. I forgot to replace all |
so that it works cross-platform
|
Thank you, the title and description now looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #14
To verify the changes, I executed
validatecommand and attached screenshot below.