Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography asset does not list correct typeface after undo via history #1230

Closed
RomanHargrave opened this issue Sep 19, 2021 · 1 comment · Fixed by #1263
Closed

Typography asset does not list correct typeface after undo via history #1230

RomanHargrave opened this issue Sep 19, 2021 · 1 comment · Fixed by #1263
Assignees
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Milestone

Comments

@RomanHargrave
Copy link

Describe the bug
If one changes the typeface of a typography asset, and then proceeds to undo the change, the asset will show the last selected typeface as opposed to the effective typeface. This persists between reloads, and project changes.

To Reproduce

  1. Create and apply a typography asset
  2. Observe that text objects using that asset reflect the stated typeface
  3. Change the typeface
  4. Observe that text objects reflect changes
  5. Access history, and revert the typeface change
  6. Observe that text objects reflect the original typeface
  7. Observe that the typography asset typeface selection does not reflect the original and effective typeface.

Expected behavior
Typography assets reflect the current and effective typeface for that asset.

Screenshots
Text showing incorrect typeface

In the above screenshot you will see that the selected text object has the 'Name' typography asset associated. The 'Name' asset indicates that Goudy Bookletter 1911 is in use when this could not be further from the truth.

What is most frustrating about this is that I did not recall what typeface was in use originally, and had to use developer tools to retrieve it from the DOM.

Desktop (please complete the following information):

  • OS: Not applicable
  • Browser (e.g. chrome, safari): Chrome (embedded, nativefier) and Firefox
  • Version (e.g. 22): Not going to bother figuring out the equivalent chrome version, FF 91

Environment (please complete the following information):
SaaS

Additional context
Add any other context about the problem here.

@myfunnyandy
Copy link
Contributor

It seems that to rollback the typeface change you need to get to the history point where the typography style was applied. I've created the bug at Taiga and we will eventually fix it: https://tree.taiga.io/project/penpot/issue/2055

@myfunnyandy myfunnyandy added the managed on taiga This issue has been moved to our project at Taiga.io label Sep 20, 2021
@Alotor Alotor mentioned this issue Oct 5, 2021
@Alotor Alotor self-assigned this Oct 5, 2021
@Alotor Alotor added this to the 1.9.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants