Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Configurable Resolver in Docker Container #3310

Closed
DaDummy opened this issue Jun 15, 2023 · 2 comments
Closed

feature: Configurable Resolver in Docker Container #3310

DaDummy opened this issue Jun 15, 2023 · 2 comments
Assignees

Comments

@DaDummy
Copy link

DaDummy commented Jun 15, 2023

Is your feature request related to a problem? Please describe.

Currently the penpot docker containers do not properly work when run with kubernetes.

This stems from the issue that the nginx resolver is hardcoded to be 127.0.0.11: https://github.com/penpot/penpot/blob/1c1397a5d85d41f1588e93cb16aa26c023257635/docker/images/files/nginx.conf#LL41C14-L41C24

But for kubernetes you need to use kube-dns.kube-system.svc as resolver instead.

Describe the solution you'd like.

Adjust nginx.conf and the Dockerfiles to allow overriding the default resolver through an environment variable as has been done for e.g. PENPOT_BACKEND_URI.

Describe alternatives you've considered.

No response

Additional context

No response

@niwinz
Copy link
Contributor

niwinz commented Jun 26, 2023

Should be fixed in 1.18.6, you should use the PENPOT_INTERNAL_RESOLVER to specify a custom resolver

@niwinz niwinz closed this as completed Jun 26, 2023
@DaDummy
Copy link
Author

DaDummy commented Jun 27, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants