Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Registration Domain Whitelist is not working with login-with-google #3348

Closed
devadattas opened this issue Jun 24, 2023 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@devadattas
Copy link

Steps To Reproduce

Steps to reproduce:

  1. Set PENPOT_REGISTRATION_DOMAIN_WHITELIST=example.com
  2. Set enable-login-with-google
  3. Setup PENPOT_GOOGLE_CLIENT_ID and PENPOT_GOOGLE_CLIENT_SECRET
  4. Now start penpot and Click on Login with Google
  5. Use any Google Account which doesn't have example.com email
  6. Registration works

Expected behavior

Using any Google account which has email different from example.com should prevent registration / login based on PENPOT_REGISTRATION_DOMAIN_WHITELIST.

Actual behavior

Using any Google account which has email different from example.com allows registration / login based ignoring PENPOT_REGISTRATION_DOMAIN_WHITELIST.

Screenshots or video

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

No response

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response

@devadattas devadattas added the bug label Jun 24, 2023
@niwinz niwinz self-assigned this Jun 26, 2023
@niwinz
Copy link
Contributor

niwinz commented Jun 26, 2023

Looks like a bug, I will look on it, thanks!

@niwinz niwinz added this to the 1.19.0 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants