Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "Fix when scrolling" renders groups invisible in preview #3508

Closed
flberger opened this issue Aug 8, 2023 · 1 comment 路 Fixed by #4235
Closed

bug: "Fix when scrolling" renders groups invisible in preview #3508

flberger opened this issue Aug 8, 2023 · 1 comment 路 Fixed by #4235
Assignees
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Milestone

Comments

@flberger
Copy link

flberger commented Aug 8, 2023

Steps To Reproduce

  1. Create some shapes
  2. Set one shape to "馃搶 Fix when scrolling" in the inspector
  3. Group the shapes
  4. Observe that all shapes are perfectly visible in the workspace
  5. Open view mode
  6. Observe that all but the fixed shapes are invisible
  7. Go back to workspace and select the offending shape within the group
  8. Observe that "馃搶 Fix when scrolling" is not available while the shape is in the group

Expected behavior

The view mode should not unexpectedly differ from the workspace view: all shapes should be visible.

If fixing a shape will inevitably create a problem in the view mode, the user should be warned about it.

Else the attribute should be cleared when an object is added to a group.

Actual behavior

The view mode unexpectedly differs from the workspace view: all but the shape set to "fix when scrolling" before are gone, for no apparent reason.

The user is not warned that adding a fixed shape to a group will render the group invisible.

The "fix when scrolling" attribute is not cleared when an object is added to a group, although it has no effect, or in the present implementation an adverse effect.

Screenshots or video

A series of shapes, with the ellipse set to "fix when scrolling".
2023-08-penpot01

The view mode is fine.
2023-08-penpot02

The objects are grouped now. Note that the inspector option "fix when scrolling" is gone.
2023-08-penpot03

In view mode, all but the offending objects are invisible.
2023-08-penpot04

Desktop (please complete the following information)

  • Artix Linux (an Arch Linux variant)
  • Chromium 117.0.5851.0 (64bit)

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

https://design.penpot.app/

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response

@flberger flberger added the bug label Aug 8, 2023
@EsterLatorre
Copy link

Hello flberger,
I've logged it in Taiga so it can get fixed. You can track the progress here
Thanks for your message!

@EsterLatorre EsterLatorre added the managed on taiga This issue has been moved to our project at Taiga.io label Aug 9, 2023
@Alotor Alotor self-assigned this Mar 7, 2024
@Alotor Alotor added this to the 1.20.0 milestone Mar 7, 2024
@Alotor Alotor linked a pull request Mar 7, 2024 that will close this issue
@Alotor Alotor closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants