Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Component font color not changing on duplicates #4512

Open
pr0pz opened this issue Apr 24, 2024 · 2 comments
Open

bug: Component font color not changing on duplicates #4512

pr0pz opened this issue Apr 24, 2024 · 2 comments
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io

Comments

@pr0pz
Copy link

pr0pz commented Apr 24, 2024

Steps To Reproduce

  1. Start self hosted version with docker compose
  2. Open any project or create a new one
  3. Create a text element
  4. Add a flex layout to it
  5. Create a component of this element
  6. Copy and paste this component elsewhere (so it's a child component)
  7. Change the text of the copied element (text override)
  8. Change the text color of the original component element

Expected behavior

When I change the text color inside the main component I'd expect that all "child" components also change the text color, regardless if I changed the actual text. Actual Text and color are different overrides.

Actual behavior

After changing the text of a child component, the text color wont sync with the main component. This would only make sense if I also changed the text color of the child component, not the text itself.

Screenshots or video

penpot-component_font_color_not_changing.mp4

Desktop (please complete the following information)

  • OS: macos sonoma 14.4.1
  • Browser: Arc 1.39.1

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

Self-Hosted:

  • OS: macos sonoma 14.4.1
  • Docker Desktop: 4.28.0 (139021)
  • Compose: v2.24.6-desktop.1
docker-compose.yaml
---
version: "3.5"

networks:
  penpot:

volumes:
  penpot_postgres_v15:
  penpot_assets:

services:
  penpot-frontend:
    image: "penpotapp/frontend:latest"
    restart: always
    ports:
      - 9001:80

    volumes:
      - penpot_assets:/opt/data/assets

    depends_on:
      - penpot-backend
      - penpot-exporter

    networks:
      - penpot

    labels:
      - "traefik.enable=true"

    environment:
      - PENPOT_FLAGS=enable-registration enable-login-with-password

  penpot-backend:
    image: "penpotapp/backend:latest"
    restart: always

    volumes:
      - penpot_assets:/opt/data/assets

    depends_on:
      - penpot-postgres
      - penpot-redis

    networks:
      - penpot
    environment:
      - PENPOT_FLAGS=enable-registration enable-login-with-password disable-email-verification enable-smtp enable-prepl-server
      - PENPOT_PUBLIC_URI=http://localhost:9001
      - PENPOT_DATABASE_URI=postgresql://penpot-postgres/penpot
      - PENPOT_DATABASE_USERNAME=penpot
      - PENPOT_DATABASE_PASSWORD=penpot
      - PENPOT_REDIS_URI=redis://penpot-redis/0
      - PENPOT_ASSETS_STORAGE_BACKEND=assets-fs
      - PENPOT_STORAGE_ASSETS_FS_DIRECTORY=/opt/data/assets
      - PENPOT_TELEMETRY_ENABLED=true
      - PENPOT_SMTP_DEFAULT_FROM=no-reply@example.com
      - PENPOT_SMTP_DEFAULT_REPLY_TO=no-reply@example.com
      - PENPOT_SMTP_HOST=penpot-mailcatch
      - PENPOT_SMTP_PORT=1025
      - PENPOT_SMTP_USERNAME=
      - PENPOT_SMTP_PASSWORD=
      - PENPOT_SMTP_TLS=false
      - PENPOT_SMTP_SSL=false

  penpot-exporter:
    image: "penpotapp/exporter:latest"
    restart: always
    networks:
      - penpot

    environment:
      - PENPOT_PUBLIC_URI=http://penpot-frontend
      - PENPOT_REDIS_URI=redis://penpot-redis/0

  penpot-postgres:
    image: "postgres:15"
    restart: always
    stop_signal: SIGINT

    volumes:
      - penpot_postgres_v15:/var/lib/postgresql/data

    networks:
      - penpot

    environment:
      - POSTGRES_INITDB_ARGS=--data-checksums
      - POSTGRES_DB=penpot
      - POSTGRES_USER=penpot
      - POSTGRES_PASSWORD=penpot

  penpot-redis:
    image: redis:7
    restart: always
    networks:
      - penpot

  penpot-mailcatch:
    image: sj26/mailcatcher:latest
    restart: always
    expose:
      - '1025'
    ports:
      - "1080:1080"
    networks:
      - penpot

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response

@pr0pz pr0pz added the bug label Apr 24, 2024
@jeremiahlee
Copy link

I can confirm this occurs on the hosted version as well.

Related bug: It's not just color. Type styles (such as a font change) on the source component do not get applied to the component instances when the text content has changed, even though the type style was not changed.

@madalenapmelo-kp
Copy link
Contributor

Hi @pr0pz @jeremiahlee,

Thanks for reporting this! This is now being tracked on Taiga.

@madalenapmelo-kp madalenapmelo-kp added the managed on taiga This issue has been moved to our project at Taiga.io label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Projects
None yet
Development

No branches or pull requests

3 participants