Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only build core once #1166

Closed
samestep opened this issue Dec 9, 2022 · 2 comments · Fixed by #1170
Closed

Only build core once #1166

samestep opened this issue Dec 9, 2022 · 2 comments · Fixed by #1170
Labels
kind:build

Comments

@samestep
Copy link
Collaborator

samestep commented Dec 9, 2022

Following up on #1160 and #1165, it would be nice to just build one @penrose/core bundle instead of two.
@maxkrieger
Copy link
Member

Nx should handle this automatically somehow :0

@samestep
Copy link
Collaborator Author

samestep commented Dec 9, 2022

😆 should it? Dunno, I'm not an Nx expert... in any case, I'm opening a PR right now to do this.

@samestep samestep mentioned this issue Dec 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Simplify core build penrose/penrose
3 participants
@maxkrieger @samestep @wodeni