Skip to content

Commit

Permalink
Bugfix: Swap plus icon with Nova's for correct viewbox (#847)
Browse files Browse the repository at this point in the history 
* Fix plus icon viewbox and rebuild

* Update changelog

* Update plus icon viewbox (remaining files)
  • Loading branch information
@JordanPak
JordanPak committed May 20, 2024
1 parent 8218636 commit a7750f8
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unpublished Changes
* Fix `plus` SVG icon `viewbox`

## 1.62.0 04-10-2024
* Remove sus `clipPathUnits` attribute from `facebook-circle` SVG
Expand Down
10 changes: 5 additions & 5 deletions build/svg/defs/sprite.defs.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
.svg-mastodon-dims { width: 559.33px; height: 600.82px; }
.svg-pinit-dims { width: 16px; height: 16px; }
.svg-pinterest-dims { width: 16px; height: 16px; }
.svg-plus-dims { width: 16px; height: 16px; }
.svg-plus-dims { width: 12.33px; height: 12.33px; }
.svg-pmc-logo-dims { width: 424.16px; height: 55.06px; }
.svg-pmc-logo-white-dims { width: 537.42px; height: 69.75px; }
.svg-print-dims { width: 166px; height: 166px; }
Expand Down Expand Up @@ -185,7 +185,7 @@
<svg viewBox="0 0 559.334 600.818" id="mastodon" xmlns="http://www.w3.org/2000/svg"><path d="M282.464 600.818h-48.01a5.57 5.57 0 0 0-1.807-.895c-3.15-.24-6.323-.217-9.461-.541-6.543-.678-13.074-1.472-19.6-2.302-5.758-.732-11.537-1.386-17.244-2.421-8.31-1.508-16.61-3.127-24.828-5.065-10.356-2.442-20.744-4.869-30.898-8.013a151.012 151.012 0 0 1-30.635-13.762 138.355 138.355 0 0 1-25.61-18.837c-5.232-4.902-10.037-10.284-14.798-15.66-8.037-9.076-14.447-19.305-20.163-29.947a238.687 238.687 0 0 1-16.898-40.213 335.312 335.312 0 0 1-12.267-50.998c-1.789-11.538-3.594-23.08-5.051-34.662-1.082-8.594-1.698-17.25-2.37-25.89q-.878-11.275-1.397-22.578c-.29-6.18-.343-12.37-.491-18.555-.027-1.087.068-2.183-.052-3.257-.04-.358-.575-.66-.884-.987V179.919c.31-.56.844-1.1.896-1.683.38-4.284.404-8.615 1.032-12.858 1.217-8.212 2.363-16.468 4.243-24.542a195.79 195.79 0 0 1 18.97-50.518 169.384 169.384 0 0 1 23.072-32.393 145.36 145.36 0 0 1 24.764-21.717 93.254 93.254 0 0 1 23.793-12.04c8.797-2.917 17.606-5.865 26.563-8.217 8.597-2.258 17.37-3.87 26.103-5.568 5.237-1.017 10.542-1.697 15.827-2.45 4.917-.7 9.845-1.323 14.774-1.929 5.16-.634 10.32-1.266 15.492-1.791 4.048-.41 8.112-.66 12.169-.974 7.96-.617 15.915-1.315 23.883-1.81 5.164-.321 10.347-.32 15.518-.538.458-.019.893-.582 1.339-.892h63.857a6.29 6.29 0 0 0 2.038.894c5.714.226 11.442.2 17.147.552 7.504.462 14.992 1.2 22.486 1.816 5.736.472 11.487.806 17.204 1.446 6.98.782 13.94 1.767 20.896 2.759 7.325 1.045 14.697 1.894 21.934 3.382 10.645 2.188 21.319 4.421 31.738 7.465A241.06 241.06 0 0 1 474.9 28.787c11.666 5.115 21.389 13.338 30.537 22.078 4.607 4.4 8.691 9.362 12.88 14.184a143.718 143.718 0 0 1 17.49 25.959 183.718 183.718 0 0 1 14.962 36.289 217.442 217.442 0 0 1 7.672 37.546c.042.392.584.73.893 1.092v101.613c-.31.56-.86 1.106-.893 1.681-.228 4.084-.325 8.176-.516 12.262-.114 2.46-.274 4.918-.494 7.37-.585 6.49-1.213 12.976-1.826 19.463-.476 5.038-.858 10.088-1.46 15.112-.646 5.38-1.453 10.742-2.277 16.1-1.079 7.01-2.007 14.054-3.432 20.996a64.72 64.72 0 0 1-10.289 23.526c-5.205 7.621-10.908 14.842-18.03 20.785-6.166 5.146-12.291 10.377-18.778 15.098a174.01 174.01 0 0 1-31.99 18.179c-5.982 2.654-11.974 5.377-18.175 7.426-9.377 3.099-18.837 6.087-28.454 8.285-9.421 2.152-19.064 3.38-28.644 4.775-5.983.87-12.031 1.284-18.048 1.925-8.604.917-17.198 1.929-25.81 2.757-6.193.595-12.403 1.08-18.616 1.393-8.56.43-17.13.91-25.694.897-9.653-.015-19.307-.513-28.958-.877-6.237-.236-12.47-.595-18.704-.929-2.148-.115-4.298-.27-6.437-.499-5.402-.579-10.796-1.226-16.197-1.817-4.569-.5-9.158-.844-13.71-1.467-7.104-.973-14.191-2.078-21.273-3.212-6.02-.963-12.036-1.965-18.026-3.097-7.547-1.425-15.066-3-23.084-4.608.434 5.572.805 11.017 1.293 16.451a90.237 90.237 0 0 0 5.541 23.966 64.86 64.86 0 0 0 24.83 31.646c10.8 7.3 22.914 11.499 35.538 13.791 11.566 2.1 23.333 3.255 35.06 4.267 9.145.789 18.363.826 27.552.988 4.94.086 9.888-.212 14.828-.439 5.383-.247 10.786-.38 16.134-.98q11.606-1.301 23.139-3.237c7.953-1.337 15.869-2.93 23.758-4.613 5.715-1.22 11.361-2.768 17.16-4.2.07.444.161.802.181 1.165.318 5.768.681 11.535.926 17.306.361 8.485.332 17.001 1.073 25.451.388 4.423-1.103 6.249-5.067 7.897a228.147 228.147 0 0 1-36.16 11.943c-11.341 2.62-22.817 4.747-34.318 6.552-8.838 1.388-17.81 1.923-26.717 2.892a5.974 5.974 0 0 0-1.806.9Zm-2.26-435.956c-3.43-5.757-6.504-11.2-9.857-16.465-4.133-6.487-7.994-13.246-12.884-19.13a70.946 70.946 0 0 0-26.257-19.769 87.652 87.652 0 0 0-33.533-7.405c-8.331-.201-16.675-.22-24.884 1.48a85.947 85.947 0 0 0-27.428 10.424 83.535 83.535 0 0 0-23.585 20.975 98.923 98.923 0 0 0-15.413 30.707 124.728 124.728 0 0 0-5.579 36.607c-.242 53.446-.09 106.894-.151 160.341-.003 2.294.708 2.857 2.91 2.848 19.033-.077 38.066-.044 57.1-.044h2.496v-3.204q0-71.781-.014-143.562c-.005-8.247.141-16.474 1.894-24.571 1.52-7.02 4.107-13.613 8.896-19.084 8.208-9.379 19.286-11.739 30.975-11.739 4.89 0 9.851 1.128 14.655 2.268a31.645 31.645 0 0 1 17.489 11.266c8.459 10.502 11.55 23.11 11.736 36.149.424 29.825.156 59.66.09 89.49-.005 2.212.567 2.918 2.853 2.908q28.432-.13 56.865.002c2.325.01 2.833-.76 2.827-2.934q-.101-36.007-.036-72.014c.007-9.331-.339-18.671 1.361-27.937 1.402-7.638 3.531-14.977 7.72-21.593a34.52 34.52 0 0 1 14.864-13.175c7.822-3.644 15.979-4.714 24.525-4.16a46.043 46.043 0 0 1 14.291 2.864 31.528 31.528 0 0 1 15.098 12.295c5.796 8.892 7.778 18.974 7.815 29.279.184 51.427.084 102.855.084 154.282v3.001h62.459v-3.17q0-77.49-.02-154.982c-.002-3.7-.147-7.413-.475-11.097-.496-5.562-1.02-11.134-1.874-16.648a101.338 101.338 0 0 0-9.12-28.864 86.137 86.137 0 0 0-21.467-28.123 84.722 84.722 0 0 0-17.707-11.762 81.123 81.123 0 0 0-31.616-8.4c-9.367-.51-18.798-.532-28.165 1.196-14.674 2.709-27.838 8.495-39.03 18.392-7.54 6.667-13.363 14.75-18.325 23.492-3.681 6.484-7.589 12.84-11.582 19.566Z"/></svg>
<svg viewBox="0 0 16 16" id="pinit" xmlns="http://www.w3.org/2000/svg"><path d="M8.717 0C4.332 0 2 2.81 2 5.874c0 1.421.794 3.193 2.065 3.755.193.087.298.05.341-.129.038-.136.205-.791.286-1.1a.283.283 0 0 0-.068-.278c-.422-.488-.757-1.377-.757-2.211 0-2.137 1.699-4.212 4.59-4.212 2.5 0 4.249 1.624 4.249 3.947 0 2.625-1.389 4.441-3.194 4.441-.999 0-1.743-.784-1.507-1.754.285-1.155.844-2.397.844-3.23 0-.747-.422-1.365-1.284-1.365-1.017 0-1.842 1.007-1.842 2.359 0 .859.304 1.439.304 1.439l-1.193 4.823c-.316 1.285.043 3.366.074 3.545.019.099.13.13.192.049.099-.13 1.315-1.865 1.656-3.119.124-.457.633-2.31.633-2.31.335.605 1.302 1.112 2.332 1.112 3.064 0 5.278-2.693 5.278-6.035C14.988 2.397 12.246 0 8.717 0"/></svg>
<svg viewBox="0 0 16 16" id="pinterest" xmlns="http://www.w3.org/2000/svg"><path d="M8.717 0C4.332 0 2 2.81 2 5.874c0 1.421.794 3.193 2.065 3.755.193.087.298.05.341-.129.038-.136.205-.791.286-1.1a.283.283 0 0 0-.068-.278c-.422-.488-.757-1.377-.757-2.211 0-2.137 1.699-4.212 4.59-4.212 2.5 0 4.249 1.624 4.249 3.947 0 2.625-1.389 4.441-3.194 4.441-.999 0-1.743-.784-1.507-1.754.285-1.155.844-2.397.844-3.23 0-.747-.422-1.365-1.284-1.365-1.017 0-1.842 1.007-1.842 2.359 0 .859.304 1.439.304 1.439l-1.193 4.823c-.316 1.285.043 3.366.074 3.545.019.099.13.13.192.049.099-.13 1.315-1.865 1.656-3.119.124-.457.633-2.31.633-2.31.335.605 1.302 1.112 2.332 1.112 3.064 0 5.278-2.693 5.278-6.035C14.988 2.397 12.246 0 8.717 0"/></svg>
<svg viewBox="0 0 16 16" id="plus" xmlns="http://www.w3.org/2000/svg"><path fill-rule="evenodd" d="M11 4.75v1.5c0 .2-.07.39-.22.53a.72.72 0 0 1-.53.22H7v3.25c0 .2-.07.39-.22.53a.72.72 0 0 1-.53.22h-1.5a.72.72 0 0 1-.53-.22.72.72 0 0 1-.22-.53V7H.75a.72.72 0 0 1-.53-.22.72.72 0 0 1-.22-.53v-1.5c0-.2.07-.39.22-.53A.72.72 0 0 1 .75 4H4V.75c0-.2.07-.39.22-.53A.72.72 0 0 1 4.75 0h1.5c.2 0 .39.07.53.22A.7.7 0 0 1 7 .75V4h3.25c.2 0 .39.07.53.22a.7.7 0 0 1 .22.53z"/></svg>
<svg viewBox="0 0 12.33 12.33" id="plus" xmlns="http://www.w3.org/2000/svg"><path d="M4.963 0h2.4v4.963h4.967v2.4H7.367v4.967h-2.4V7.367H0v-2.4h4.963Z" fill-rule="evenodd"/></svg>
<svg viewBox="0 0 424.16 55.06" id="pmc-logo" xmlns="http://www.w3.org/2000/svg"><path d="M424.15 55.06h-98.88c-11.84 0-20.75-5-20.75-17.28V18.19c0-12.62 7.3-18.19 21.19-18.19h98.44v7.68h-98.28c-7.53 0-13.2 2.4-13.2 10.68v18.87c0 6.48 4.69 10.18 12.38 10.18h99.11v7.65ZM119.39 19.79c0 8.35-7.16 12.54-15.46 12.54H8.36v22.72H0V24.79h104.32c4.6 0 7-1.74 6.93-6.1l-.06-5.18c0-4.6-2.16-5.72-6.87-5.72H0V0h105.2c7.76 0 14.2 3.1 14.2 11v8.8ZM138 55.05h8.36V15.61l-8.36-4Zm74-23.54L146.33 0H138v5.29l66.11 31.76a19.32 19.32 0 0 0 7.89 1.77Zm73.93 23.54h-8.36V15.6l8.36-4Z"/><path d="M212 31.51 277.58 0h8.36v5.29l-66.11 31.76a19.28 19.28 0 0 1-7.83 1.77Z" style="fill:#e50019"/></svg>
<svg viewBox="0 0 537.42 69.75" id="pmc-logo-white" xmlns="http://www.w3.org/2000/svg"><path d="M537.42 69.75H412.13c-15 0-26.28-6.29-26.28-21.89V23c0-16 9.24-23 26.84-23h124.73v9.73H412.89c-9.53 0-16.73 3-16.73 13.52v23.92c0 8.2 5.94 12.89 15.69 12.89h125.57v9.69zM151.28 25.06c0 10.59-9.08 15.9-19.59 15.9H10.6v28.79H0V31.41h132.17c5.84 0 8.85-2.22 8.79-7.74l-.07-6.55c-.06-5.83-2.74-7.25-8.72-7.25H0V0h133.29c9.83 0 18 3.93 18 13.91v11.15zm23.55 44.69h10.6l-.02-49.98-10.59-5.11.01 55.09zm93.73-29.82L185.41 0h-10.59v6.7l83.77 40.24a24.31 24.31 0 0 0 10 2.24zm93.73 29.82H351.7l.01-49.98 10.59-5.11-.01 55.09z" style="fill:#fff"/><path d="M268.56 39.93 351.71 0h10.59v6.7l-83.77 40.24a24.31 24.31 0 0 1-10 2.24z" style="fill:#ed1c24"/></svg>
<svg viewBox="0 0 166 166" id="print" xmlns="http://www.w3.org/2000/svg"><style>.ayst1{fill:#fff}</style><g id="ayprint_1_" transform="translate(1251 1399)"><g id="ayGroup-3_1_" transform="translate(0 .992)"><defs><filter id="ayAdobe_OpacityMaskFilter" x="-1251" y="-1400" width="166" height="166"><feColorMatrix values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 0 0 0 1 0"/></filter></defs><mask maskUnits="userSpaceOnUse" x="-1251" y="-1400" width="166" height="166" id="aymask-2_1_"><g filter="url(#ayAdobe_OpacityMaskFilter)"><path id="aypath-1_1_" class="ayst1" d="M-1251-1400h166v166h-166z"/></g></mask><path id="ayFill-1_1_" d="M-1113.8-1317c5.2 0 9.6-4.3 9.6-9.4 0-5.3-4.2-9.7-9.4-9.7-5.4 0-9.7 4.2-9.7 9.6 0 5.2 4.3 9.5 9.5 9.5zm-99.1-31.9h89.4v-31.6c0-.4 0-.8-.1-1.2-.6-3.3-3.1-5.4-6.5-5.4h-76.1c-.5 0-1.1 0-1.6.2-3.1.7-5 3.1-5 6.4v31.2l-.1.4zm0 44.7v50.9c0 .4 0 .8.1 1.2.6 3.3 3.1 5.4 6.6 5.4h76.1c.5 0 1 0 1.5-.1 3.2-.7 5.2-3.1 5.2-6.5v-50.8h-89.5zm5.1-95.8h79.2c.2 0 .3.1.5.1 2.4.2 4.7.8 6.8 2 6.9 3.8 10.5 9.6 10.6 17.5v31.6h6.9c2.9 0 5.7.6 8.2 2 7 3.7 10.6 9.5 10.7 17.4.1 12.6 0 25.2 0 37.8 0 1.1-.1 2.2-.2 3.2-.6 3.6-2.1 6.9-4.5 9.6-3.7 4.2-8.4 6.4-14 6.5-2.1.1-4.2 0-6.4 0h-.6v18.9c0 3.1-.6 6-2 8.7-3.7 6.9-9.6 10.6-17.5 10.6-25.2.1-50.4 0-75.6 0-1 0-2.1-.1-3.1-.2-5-.7-9.1-3-12.3-6.9-3-3.6-4.4-7.8-4.4-12.5v-18.7h-6.1c-1.2 0-2.3-.1-3.5-.3-7.4-1.3-13.6-7.1-15.2-14.4-.2-1-.4-2-.5-3v-41.1c0-.1.1-.2.1-.3.2-2.7 1-5.3 2.4-7.6 3.7-6.2 9.2-9.5 16.5-9.7 1.8-.1 3.7 0 5.5 0h.8v-31.5c0-1 0-2.1.2-3.1 1-7.7 7-14.3 14.6-16 .8-.3 1.9-.4 2.9-.6z" mask="url(#aymask-2_1_)"/></g><defs><filter id="ayAdobe_OpacityMaskFilter_1_" x="-1199.9" y="-1290.4" width="63.8" height="12.7"><feColorMatrix values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 0 0 0 1 0"/></filter></defs><mask maskUnits="userSpaceOnUse" x="-1199.9" y="-1290.4" width="63.8" height="12.7" id="aymask-4_2_"><g filter="url(#ayAdobe_OpacityMaskFilter_1_)"><path id="aypath-3_2_" class="ayst1" d="M-1251-1233h166v-166h-166z"/></g></mask><path id="ayFill-4_1_" mask="url(#aymask-4_2_)" d="M-1199.9-1277.8h63.8v-12.6h-63.8z"/><defs><filter id="ayAdobe_OpacityMaskFilter_2_" x="-1199.9" y="-1271.3" width="44.6" height="12.7"><feColorMatrix values="1 0 0 0 0 0 1 0 0 0 0 0 1 0 0 0 0 0 1 0"/></filter></defs><mask maskUnits="userSpaceOnUse" x="-1199.9" y="-1271.3" width="44.6" height="12.7" id="aymask-4_1_"><g filter="url(#ayAdobe_OpacityMaskFilter_2_)"><path id="aypath-3_1_" class="ayst1" d="M-1251-1233h166v-166h-166z"/></g></mask><path id="ayFill-6_1_" mask="url(#aymask-4_1_)" d="M-1199.9-1258.6h44.6v-12.7h-44.6z"/></g></svg>
Expand Down Expand Up @@ -398,7 +398,7 @@ <h2>pinterest, </h2>
</li>
<li title="plus">
<div class="icon-box">
<svg viewBox="0 0 16 16" class="svg-plus-dims">
<svg viewBox="0 0 12.33 12.33" class="svg-plus-dims">
<use xlink:href="#plus"></use>
</svg>
</div>
Expand Down Expand Up @@ -713,7 +713,7 @@ <h2>pinterest, </h2>
</li>
<li title="plus">
<div class="icon-box">
<svg viewBox="0 0 16 16" class="svg-plus-dims">
<svg viewBox="0 0 12.33 12.33" class="svg-plus-dims">
<use xlink:href="sprite.defs.svg#plus"></use>
</shapes>
</div>
Expand Down Expand Up @@ -847,7 +847,7 @@ <h2>youtube, </h2>

</section>
<footer>
<p>Generated at Wed, 10 Apr 2024 20:31:06 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
<p>Generated at Mon, 20 May 2024 14:50:50 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
</footer>
</body>
</html>
2 changes: 1 addition & 1 deletion build/svg/defs/sprite.defs.svg
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/larva-svg/src/svg/plus.svg
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit a7750f8

Please sign in to comment.