Use round func to prevent errors with floating nums (#762)

* use round func to prevent errors with floating * update changelog * add separator thickness class prop * update changelog * npm run prod
penske-media-corp · Jan 24, 2023 · fce756f · fce756f · vercel · Jan 24, 2023
1 parent 049cbca
commit fce756f
Show file tree

Hide file tree

Showing 19 changed files with 68 additions and 65 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## Unpublished Changes
+* larva-scss - Use `round` func when generating font size utility classes (via `@mixin u-font-size`) to prevent errors when converting rems to pixels for class name.
+* larva-patterns - Add `separator_thickness_class` to modules/separator pattern.
 
 ## 1.42.0 01-17-2023
 * larva-patterns - Add conditionally usable `rel` attribute to o-card object.

diff --git a/build/css/larva-important.css b/build/css/larva-important.css
diff --git a/build/css/larva.css b/build/css/larva.css
diff --git a/build/css/larva.inline-important.css b/build/css/larva.inline-important.css
diff --git a/build/css/larva.inline.css b/build/css/larva.inline.css
diff --git a/build/svg/defs/sprite.defs.html b/build/svg/defs/sprite.defs.html
@@ -846,7 +846,7 @@ <h2>youtube</h2>
 
 		</section>
 		<footer>
-			<p>Generated at Wed, 14 Dec 2022 17:36:14 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
+			<p>Generated at Tue, 24 Jan 2023 19:37:23 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
 		</footer>
 	</body>
 </html>
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/larva-css/build/css/algorithms.common.inline.css b/packages/larva-css/build/css/algorithms.common.inline.css
diff --git a/packages/larva-css/package-lock.json b/packages/larva-css/package-lock.json
diff --git a/packages/larva-patterns/modules/separator/separator.prototype.js b/packages/larva-patterns/modules/separator/separator.prototype.js
@@ -1,4 +1,5 @@
 module.exports = {
 	separator_classes: 'lrv-u-border-a-1',
 	separator_border_color_class: '',
+	separator_thickness_class: '',
 };
diff --git a/packages/larva-patterns/modules/separator/separator.twig b/packages/larva-patterns/modules/separator/separator.twig
@@ -1 +1 @@
-<hr class="separator larva // {{ separator_classes }} {{ separator_border_color_class }}" />
+<hr class="separator larva // {{ separator_classes }} {{ separator_border_color_class }} {{ separator_thickness_class }}" />
diff --git a/packages/larva-patterns/package-lock.json b/packages/larva-patterns/package-lock.json
diff --git a/packages/larva-scss/lib/tools/generators/_text-utility-generator.scss b/packages/larva-scss/lib/tools/generators/_text-utility-generator.scss
@@ -38,9 +38,9 @@
 
 			@if (length($token) == 2) {
 				$at: \@;
-				$selector: ".#{$NAMESPACE}u-#{$property}-#{_strip-unit($value) * 16}#{$at}#{$breakpoint}";
+				$selector: ".#{$NAMESPACE}u-#{$property}-#{round(_strip-unit($value) * 16)}#{$at}#{$breakpoint}";
 			} @else {
-				$selector: ".#{$NAMESPACE}u-#{$property}-#{_strip-unit($value) * 16}";
+				$selector: ".#{$NAMESPACE}u-#{$property}-#{round(_strip-unit($value) * 16)}";
 			}
 
 		}

diff --git a/packages/larva/build/css/larva-important.css b/packages/larva/build/css/larva-important.css
diff --git a/packages/larva/build/css/larva.css b/packages/larva/build/css/larva.css
diff --git a/packages/larva/build/css/larva.inline-important.css b/packages/larva/build/css/larva.inline-important.css
diff --git a/packages/larva/build/css/larva.inline.css b/packages/larva/build/css/larva.inline.css
diff --git a/packages/larva/build/svg/defs/sprite.defs.html b/packages/larva/build/svg/defs/sprite.defs.html
@@ -846,7 +846,7 @@ <h2>youtube</h2>
 
 		</section>
 		<footer>
-			<p>Generated at Wed, 14 Dec 2022 17:36:14 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
+			<p>Generated at Tue, 24 Jan 2023 19:37:23 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
 		</footer>
 	</body>
 </html>
diff --git a/packages/larva/package-lock.json b/packages/larva/package-lock.json