Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASE-1528 add flipboard branding to larva #793

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

shawncook
Copy link
Contributor

@shawncook shawncook commented Apr 24, 2023

redo from #792

  • Adds Flipboard logo svg and brand color variable.
  • Ran npm run build-icons to compile SVG sprite with additional image
  • Addition of scss var doesn't require css build. Per readme: This repository provides **Sass files only**. The consuming project is responsible for building the assets..

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pmc-larva ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 3:47pm

@shawncook shawncook merged commit ffcb356 into master Apr 25, 2023
3 checks passed
@shawncook shawncook deleted the feature/PASE-1528-flipboard branch April 25, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants