Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Remove space ( ) and comma (,) encoding from inline-svg function #825

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

JordanPak
Copy link
Contributor

@JordanPak JordanPak commented Nov 3, 2023

For PASE-1817 (Node 18 upgrades). Fixes prod:scss for Hollywood Reporter and Rolling Stone, which were getting "stuck" in the encoding function for misc. SVGs. The resulting url() still works with the spaces and commas in major browsers (tried Chrome, Firefox, Safari).

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-gxsp6kztj-penske-media-corp.vercel.app

Built with commit 78cc7d4.
This pull request is being automatically deployed with vercel-action

@JordanPak JordanPak merged commit 2d27ced into master Nov 6, 2023
3 checks passed
@JordanPak JordanPak deleted the bugfix/node-18-inline-svg-encoder branch November 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants