Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Re-enable SVG space character encoding + fix "freezing" CSS compilation #829

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

JordanPak
Copy link
Contributor

@JordanPak JordanPak commented Nov 13, 2023

  • Re-enabled to %20 encoding in url-encode() SCSS function so built CSS is compatible with minification/concatenation in WordPress
  • Fix "freezing" issue in str-replace() caused by too much happening in one statement

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-4dryu8hz2-penske-media-corp.vercel.app

Built with commit 89783eb.
This pull request is being automatically deployed with vercel-action

@JordanPak JordanPak merged commit cd53e54 into master Nov 13, 2023
3 checks passed
@JordanPak JordanPak deleted the bugfix/inline-svg-encoding branch November 13, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants