Add a Block Editor based on Editor.js #179
Conversation
wmnnd
force-pushed
the
feature/editorjs
branch
6 times, most recently
from
891ebd8
to
c236dbe
Compare
Also moves the markdown WYSIWYG editor to a new folder
This includes a patch required for making nested templates possible in Keila
wmnnd
force-pushed
the
feature/editorjs
branch
from
c236dbe
to
57d1bdc
Compare
|
It’s finally here! 🥳 @everyone: I would like to merge this PR next week, and would be very grateful for feedback before that - maybe there are still some bugs I haven’t yet managed to find 🐞
|
|
@panoramix360 & @gbottari As always, your feedback would be especially appreciated 😊 |
This non-reversible migrations transforms old template styles to be compatible with the new HybridTemplate.
|
I'm taking a look piece by piece, it's a very long PR haha |
|
@panoramix360 What do you think, is the PR ready to be released? 😅 |
|
I made a lot of comments :) They are just suggestions feel free to let me know what you think! I never worked with Liquid template system so it's cool to take a look haha I'm sorry for taking so long to review, I'll try to be better in my next responses. It's nice to be back looking through Elixir code 😃 |
|
@panoramix360 Thank you for adding your comments, I think you’re making some very good points! At this point I feel like I want to ship the new feature as soon as possible and then do some refactoring at the same time as users are already trying out the new experience. Have you been able to play around with the new features from a user side a bit and have you found any blockers (from a user perspective) there? |
|
@wmnnd no problem :D I didn't have the time to play around as a user, I just looked through the code. But you can merge the push and I'll look after it, if any bugs or things appear I'll create an issue then, what do you think? |
Sure, that would be great! Though I’m not gonna merge it before next week, because I’m currently at ElixirConf EU 😃 |
Oh nice!! :D Are you showcasing the project there? How is it going? |
The change we made for Keila has since been merged
This is a WIP branch for implementing #175.
The Block editor will be added as an alternative to the existing Markdown and plain text editors.