Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the git commit hash from the Linux build process #47

Closed
pentix opened this issue Mar 28, 2020 · 1 comment
Closed

Remove the git commit hash from the Linux build process #47

pentix opened this issue Mar 28, 2020 · 1 comment

Comments

@pentix
Copy link
Owner

pentix commented Mar 28, 2020

See #41 (comment)

@pentix
Copy link
Owner Author

pentix commented Apr 4, 2020

I did some more research on this [1], [2] and found there is not really a cross-platform way to obtain the latest git revision before compiling qjournalctl. It's additionally difficult since git can be installed everywhere on a windows system and might not be available in %PATH% therefore the user would need to set it - just like the Qt and msvc path. I assume most users on Windows would use the precompiled binaries anyway, where the git revision would not be shown.

Also, it's probably "more fancy than a feature", i.e. the use is very limited, so I might as well just remove it in the linux build process.

[1] https://www.everythingfrontend.com/posts/app-version-from-git-tag-in-qt-qml.html

[2] https://stackoverflow.com/questions/27041573/print-git-hash-in-qt-as-macro-created-at-compile-time/27062550

@pentix pentix removed this from the Windows Release milestone Apr 4, 2020
@pentix pentix changed the title Build: Find a better solution reading the base commit a build is based on Remove the git commit hash from the Linux build process Apr 4, 2020
@pentix pentix closed this as completed in 8d6d045 Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant