-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QJournalctl win32 x64 port. #41
QJournalctl win32 x64 port. #41
Conversation
…, build and package of the qjournalctl applcation
…on on variable definition by malloc-style memory allocation.
…pveyor.yml configuration for releasing Windows Artifacts
As already stated in my previous email, I'd suggest some changes: 😌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some cosmetic issues actually
REM --------------------------------------------------------------------- | ||
set OLD_PATH=%PATH% | ||
rem "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x86 | ||
rem set QTDIR=C:\Qt\Qt5.14.1\5.14.1\msvc2017 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an simple method to display the actually executed commands? This could get misleading/confusing if we log version A but execute version B...
set OLD_PATH=%PATH% | ||
rem "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x86 | ||
rem set QTDIR=C:\Qt\Qt5.14.1\5.14.1\msvc2017 | ||
rem "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding call .....\.....\vcvarsall.bat x64
directly for the user? I guess the problem is we would need to find the correct installation path of Visual Studio, right? 😬
rem qmake qjournalctl.pro CONFIG+=release VCPKG_FOLDER=. | ||
|
||
rem 64 bits | ||
qmake qjournalctl.pro CONFIG+=release CONFIG+=x86_64 VCPKG_FOLDER=%VCPKG_INSTALL_FOLDER% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before starting the build, it would be nice to have version.h
adjusted just as the autogen.sh
script does. (
Line 19 in 90e299a
if [ -d ".git" ]; then |
However I'm almost sure there's a better (and more portable) way of doing this than what I'm doing right now...
(Maybe qmake itself offers a solution to this?)
What?
This is a contribution which aims to port the
QJournalctl
application to Windows.Details
The major contribution is
appveyor
configuration to be able to directly obtain the released artifacts from there (deployed artifacts)There are some few changes applied to the codebase:
usleep
to a multi-platform equivalent callmsvc
build rules. Migrated to safermalloc
based initialization.Also to the
README.md
building
chapterRemaining tasks