Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing convertion trait implementations #97

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

neithanmo
Copy link
Contributor

The no_std/alloc counterpart for encoding was missing the TryFrom and From conversion implementations for [u8; 32]. This PR add those

@neithanmo neithanmo changed the title Add useful convertion trait implementation Add missing convertion trait implementations Mar 21, 2024
Copy link
Member

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@redshiftzero redshiftzero merged commit 130bf15 into penumbra-zone:main Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants