chain: record NoteSources in CompactBlocks
#1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow a client to determine the provenance of a note they detect, which might or might not have been created by a particular transaction. Without this data, it's difficult for a client to determine the source of the notes they detect, even if they download a full block, because some notes are created as a result of chain-wide logic, rather than any particular transaction in the block. This commit does not yet add this information into the `NoteRecord`s in the view service, but that's the next step.
hdevalence
force-pushed
the
note-source-in-compact-block
branch
from
9c8beaf
to
5c20483
Compare
hdevalence
force-pushed
the
note-source-in-compact-block
branch
from
5c20483
to
7e99c42
Compare
Co-Authored-By: Aubrey Dyer <aubrey@penumbra.zone>
hdevalence
force-pushed
the
note-source-in-compact-block
branch
from
7e99c42
to
4c64591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a client to determine the provenance of a note they detect,
which might or might not have been created by a particular transaction. Without
this data, it's difficult for a client to determine the source of the notes
they detect, even if they download a full block, because some notes are created
as a result of chain-wide logic, rather than any particular transaction in the
block.
This commit does not yet add this information into the
NoteRecords in theview service, but that's the next step.