Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol: lift memos to transaction level #1371

Merged
merged 2 commits into from Sep 8, 2022
Merged

protocol: lift memos to transaction level #1371

merged 2 commits into from Sep 8, 2022

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Sep 7, 2022 •
edited

Closes #1222

Followup:

  • Add consensus rule to check we only have memos for transactions with outputs

@redshiftzero redshiftzero temporarily deployed to smoke-test September 7, 2022 20:07 Inactive
@redshiftzero redshiftzero temporarily deployed to smoke-test September 7, 2022 21:30 Inactive
@redshiftzero redshiftzero marked this pull request as ready for review September 7, 2022 21:30
@avahowell
Copy link
Member

LGTM

@redshiftzero redshiftzero merged commit 305d20b into main Sep 8, 2022
@redshiftzero redshiftzero deleted the memo-lift branch September 8, 2022 20:26
@daira daira mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lift Memo to transaction level
2 participants
@redshiftzero @avahowell