crypto(zk): impl R1CSVar
for our circuit variables
#2113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The R1CSVar trait is very useful for debugging as it lets you call
.value()
to learn what value the variable has in the constraint system. This PR implements it for most of our circuit variables, though I've noted a couple of places where it doesn't make sense, e.g. we can't reconstruct a fullNote
because we don't have the rseed in-circuit, only the derived values.Related to #2040