Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add witness_and_build rpc #2146

Merged
merged 11 commits into from
Mar 11, 2023
Merged

client: add witness_and_build rpc #2146

merged 11 commits into from
Mar 11, 2023

Conversation

aubrika
Copy link
Contributor

@aubrika aubrika commented Mar 10, 2023

Closes #1883

@aubrika aubrika temporarily deployed to smoke-test March 10, 2023 21:35 — with GitHub Actions Inactive
@hdevalence
pclientd: split into separate crate
c06e0e7
@hdevalence
pclientd: add network integration test
e445a95
@hdevalence
pclientd: move implementation into library code
f4d4e95 
This means that the binary is just a thin wrapper around reusable library code.
@hdevalence
pclientd: pull out utility methods, allow start without init
5df578b 
Factoring out common `init_sqlite` and `load_or_init_sqlite` methods lets
`pclientd` start when the config file is manually written, not just after
`pclientd init` which autogenerates it.
@hdevalence
pclientd: rename config struct
d37833d
@hdevalence
pclientd(test): switch to tokio's Command
8dacae8
@hdevalence hdevalence temporarily deployed to smoke-test March 11, 2023 01:26 — with GitHub Actions Inactive
@hdevalence hdevalence temporarily deployed to smoke-test March 11, 2023 01:55 — with GitHub Actions Inactive
@hdevalence hdevalence temporarily deployed to smoke-test March 11, 2023 02:42 — with GitHub Actions Inactive
@hdevalence hdevalence merged commit a63ebb6 into main Mar 11, 2023
@hdevalence hdevalence deleted the 1883-transaction-build-rpc branch March 11, 2023 17:51
aubrika
aubrika commented Mar 13, 2023
View reviewed changes
Copy link
Contributor Author

@aubrika aubrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, looks good, thanks for wrapping it up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TransactionBuild RPC
2 participants
@aubrika @hdevalence