Attempt to convert pcli's ORM to use rusqlite instead of sqlx
#2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the implementor of AsyncRead/AsyncWrite/Read/Write to choose what iterator or stream is returned, which is useful when using rusqlite, because rusqlite's iterators are `!Send`, so we need to customize that bound when returning a `dyn Iterator` (i.e. it can't be hardcoded to `Send` in the trait definition).
We will incrementally fill in the converted functionality
hdevalence
reviewed
Apr 18, 2023
| @@ -0,0 +1,119 @@ | |||
| -- The hash of this schema file | |||
There was a problem hiding this comment.
Does this need to live inline with the Rust code? Could we keep it in view/schema/view.sql (rather than "migrations")?
hdevalence
reviewed
Apr 18, 2023
hdevalence
reviewed
Apr 18, 2023
hdevalence
reviewed
Apr 18, 2023
|
hdevalence
force-pushed
the
pcli-rusqlite
branch
from
bcccc20
to
84fe0c0
Compare
For posterity: this was caused by not using the |
This was referenced Apr 19, 2023
conorsch
pushed a commit
to penumbra-zone/galileo
that referenced
this pull request
Apr 27, 2023
Uses the new storage init logic [0] to store sync state in memory. This will cause galileo to sync at service start to memory, and abjure any on-disk storage. Hat tip to @plaidfinch for explaining the type inference required by the view service changes. [0] penumbra-zone/penumbra#2372
conorsch
pushed a commit
to penumbra-zone/galileo
that referenced
this pull request
Apr 27, 2023
Uses the new storage init logic [0] to store sync state in memory. This will cause galileo to sync at service start to memory, and abjure any on-disk storage. Hat tip to @plaidfinch for explaining the type inference required by the view service changes. [0] penumbra-zone/penumbra#2372
plaidfinch
pushed a commit
to penumbra-zone/galileo
that referenced
this pull request
Apr 27, 2023
Uses the new storage init logic [0] to store sync state in memory. This will cause galileo to sync at service start to memory, and abjure any on-disk storage. Hat tip to @plaidfinch for explaining the type inference required by the view service changes. [0] penumbra-zone/penumbra#2372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc<Mutex<rusqlite::Connection>>(this is temporary)pcli,pclientd, andgalileo(things might be really slow because of the global mutex, especially galileo)Arc<Mutex<...>>with anr2d2::Pool<r2d2_sqlite::SqliteConnectionManager>, so we can (hopefully) read while writing, etc.Might need to re-enable table-level locking using the "shared cache" like we did previously even though rusqlite (and the sqlite docs) warn against it? Consider this carefully...