Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: support alt-encoding bech32 values #2688

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

hdevalence
Copy link
Member

Closes #2666.

This allows RPC clients to use bech32 values anywhere that an Address, AssetId, or PositionId is supplied. However, our Rust domain types never produce bech32 encodings, to ensure that we maintain canonical encoding.

Closes #2666.

This allows RPC clients to use bech32 values anywhere that an `Address`,
`AssetId`, or `PositionId` is supplied.  However, our Rust domain types never
produce bech32 encodings, to ensure that we maintain canonical encoding.
@hdevalence hdevalence temporarily deployed to smoke-test June 8, 2023 01:38 — with GitHub Actions Inactive
@hdevalence hdevalence merged commit 6ca40c6 into main Jun 8, 2023
@hdevalence hdevalence deleted the alt-proto-encodings branch June 8, 2023 02:01
@cratelyn cratelyn added the protobuf-changes Makes changes to the protobuf definitions. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DenomMetadataById to support string-encoded asset IDs
2 participants