Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get to version 1 #61

Open
6 of 12 tasks
penx opened this issue Feb 9, 2018 · 7 comments
Open
6 of 12 tasks

Get to version 1 #61

penx opened this issue Feb 9, 2018 · 7 comments
Projects
Milestone

Comments

@penx
Copy link
Member

penx commented Feb 9, 2018

This serves as a checklist of what we need to do to get to version 1.

  • implement all standard components we're aware of
  • example site should show usage of all exported components
  • all form components and validation should be working with final form in example site as expected
  • collaborator review of all markup/props used by example site
  • storybook review
  • generate list of all exported components + props (api documentation)
  • working usage in an internal tool
  • decision on grid tooling decided
  • API documentation Generate API.md #64
  • Form fields and inputs have a naming convention, documented in the readme, and follow the same prop structure
  • asAnchor pattern is consistent, working and compared with how other libraries manage this
    • a common approach for active links (as per react-router NavLink) decided

Conventions are consistent and present in README:

  • white space
  • anchors
  • form fields vs. inputs
@marksy
Copy link
Collaborator

marksy commented Feb 12, 2018

implement all standard components we're aware of

i'll start a list of standard components so we're clear what we're considering

@marksy
Copy link
Collaborator

marksy commented Feb 12, 2018

For removal from this list? (Non-standard components)

  • tabs?
  • modal window?

@penx
Copy link
Member Author

penx commented Feb 26, 2018

recommendation from Steve on Grid

Export grid from govuk-react as it is based on existing govuk styles, but this is optional and expect parent project to be able to use it's own grid tooling.

@penx
Copy link
Member Author

penx commented Apr 3, 2018

  • top banner, and getting the example site to look like a full GDS page without any additional styles needed

@penx
Copy link
Member Author

penx commented May 2, 2018

@penx
Copy link
Member Author

penx commented May 2, 2018

@Loque-
Copy link
Collaborator

Loque- commented May 18, 2018

The example site could copy the prototype toolkit? Would help be some form of benchmark/validation target. (See page templates: https://govuk-prototype-kit.herokuapp.com/docs/tutorials-and-examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1
  
To do
Development

No branches or pull requests

3 participants