Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract configs to another project in order to make this one public some day #12

Closed
amessinger opened this issue Oct 29, 2014 · 3 comments

Comments

@amessinger
Copy link
Contributor

The private project would pull this one as a dependency

@benoitbryon
Copy link

Apart from the "make this project public", using external configuration files would improve the dependency graph between crappyspider and web applications:

  • URLs are created and maintained in web applications (a.k.a Django projects)
  • this project (crappyspider) is valid for a given version of web applications, i.e. when an URL is updated in a project, we have to update it here too. In the meantime, crappyspider is broken
  • moving configuration inside web applications would make the workflow more consistent: list of URLs will be updated along with the code, and crappyspider would not be affected by changes in applications.

@amessinger
Copy link
Contributor Author

As seen #17, config files will be moved to the crawled projects themselves. We will keep a sample file in the repository.

@amessinger
Copy link
Contributor Author

Done in #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants