Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature model has signature_id attribute #7

Closed
benoitbryon opened this issue Oct 13, 2014 · 0 comments
Closed

Signature model has signature_id attribute #7

benoitbryon opened this issue Oct 13, 2014 · 0 comments
Labels
Milestone

Comments

@benoitbryon
Copy link
Contributor

Just like signature_backend_id attribute identifies the signature on backend side, we need an identifier on local (Django) side. Because, just as in Django side we store external backend ID, in external backend we may store Django's id. Default primary key (integer id) is not enough. Something like an uuid would be welcome.

Another use case is URL construction: it is better if "signer return" and "callback" URL contain signature uuid:

  • it is quick and easy to get the signature object matching the request. We can use a SingleObjectMixin whatever the backend.
  • it is a bit harder for clients to "guess" a valid URL and try various POST/GET requests. They need a valid signature identifier.

UUID should be the default implementation, but of course this must be overridable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant