Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with Django 1.11 #22

Merged
merged 1 commit into from Sep 13, 2017
Merged

Run tests with Django 1.11 #22

merged 1 commit into from Sep 13, 2017

Conversation

hsmett
Copy link
Contributor

@hsmett hsmett commented Aug 24, 2017

No description provided.

Copy link
Contributor

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny changes asked in the Changelog. for the rest, LGTM

CHANGELOG.md Outdated
@@ -2,7 +2,7 @@

# master (unreleased)

Nothing here yet, stay tuned.
- Run tox with Django 1.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add:

env: TOXENV=flake8-py27

- python: 3.4
env: TOXENV=flake8-py34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why the need to run flake8 with 2 different Python versions? shouldn't the result be the same?

- python: 3.6
env: TOXENV=py36-djangomaster

allow_failures:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! didn't know about this one! excellent!

Update tox & travis configurations to run tests with the full python-django support map (adding django 1.11 & master)
Fix Django 2.0
@brunobord brunobord merged commit 03bfd7c into peopledoc:master Sep 13, 2017
@brunobord
Copy link
Contributor

I guess you're going to need a release, right?
Please ping me tomorrow morning ;o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants