Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheels support #1

Closed
Natim opened this issue Nov 13, 2013 · 14 comments
Closed

Add wheels support #1

Natim opened this issue Nov 13, 2013 · 14 comments

Comments

@Natim
Copy link
Contributor

Natim commented Nov 13, 2013

http://pythonwheels.com/

@tmartinfr
Copy link
Contributor

tmartinfr commented Oct 4, 2016

Wheel packages can be created using: python setup.py bdist_wheel.

@FlogFr
Copy link

FlogFr commented Oct 4, 2016

They also can be universal to use the same wheel between py2 and py3 :)

@Natim
Copy link
Contributor Author

Natim commented Oct 4, 2016

The way we do it usually is by configuring setup.cfg like that: https://github.com/Kinto/kinto-changes/blob/master/setup.cfg

@tmartinfr
Copy link
Contributor

@Natim It should probably depends on general guidelines for every Python novafloss projects. Would you agree to close this old issue ?

@tmartinfr
Copy link
Contributor

@Natim I close, re-open it if necessary !

@Natim
Copy link
Contributor Author

Natim commented Jan 4, 2017

I didn't get that you wanted to close it without actually fixing it, can I file a pull-request for it?

@tmartinfr
Copy link
Contributor

@Natim Because it's a very old issue and nobody plans to work on it. But of course you're welcome to submit a PR !

@Natim
Copy link
Contributor Author

Natim commented Jan 4, 2017

Ok I just did then :) #50

@tmartinfr
Copy link
Contributor

@Natim Thanks I'm looking at it

@tmartinfr tmartinfr reopened this Jan 4, 2017
@tmartinfr
Copy link
Contributor

@Natim Looks good, but I guess we have to wait for #40 and #49 before publishing py3 wheels.

@Natim
Copy link
Contributor Author

Natim commented Jan 4, 2017

We won't publish py3 wheels we are pushing an universal one and only people using py2 will use it before merging Py3 support :)

@tmartinfr
Copy link
Contributor

@Natim I don't understand why we would want to create universal wheel file while the package is not currently universal ? If I refer to http://pythonwheels.com/ :

Note: If your project is python 2 and 3 compatible you can create a universal wheel distribution.

Maybe we could remove the [bdist_wheel] section in the PR ? If so, it would be ok for me to merge. Then we could add it back after #49.

@Natim
Copy link
Contributor Author

Natim commented Jan 4, 2017

I believe it depends if you plan on merging #49 before the next release or not...

@tmartinfr
Copy link
Contributor

@Natim I have to test it. Meanwhile your PR can stay open and I'll merge it when appropriate :-)

mike-perdide pushed a commit that referenced this issue Jan 3, 2022
mike-perdide pushed a commit that referenced this issue Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants