Add support for expressions in the Text generator #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 85.88% 85.94% +0.06%
==========================================
Files 34 34
Lines 1155 1160 +5
==========================================
+ Hits 992 997 +5
Misses 163 163
Continue to review full report at Codecov.
|
k4nar
reviewed
Oct 11, 2017
tests/test_generators.py
Outdated
|
|
||
| assert len(sample) == 10 | ||
| assert all((1 <= len(e) <= 4) for e in sample) | ||
|
|
There was a problem hiding this comment.
maybe we should also add a test with max_length=0 as there was apparently a bug with it :)
k4nar
approved these changes
Oct 11, 2017
|
Closes #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.